You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The SpecreduceOperation class has as its superclass _ImageParser. That seems to do nothing other than offering a _parse_image method, which notable coerces Everything into a Spectrum1D object (
In a spectroscopic workshop last week, several people were confused by this given that most of the operations illustrated here: #71 do not take in an image and output a spectrum1D. Many instead take in or output spectrumcollection, or take in spectrum1d, etc.
It's actually unclear to me why this class even exists. It seems to do a very specific parsing operation that's used a couple different places but very confusingly - e.g. an "image" is converted into a spectrum1D but then set to be an image, whereas an image really should be an image class (i.e., a CCDImage) unless it has a meaningful wavelength solution.
It's possible this is all just an oversight, as that particular code hasn't been touched in like a year or more even as other things were implemented. It might be the straightforward fix is to remove the subclass and instead implement this as some kind of utility function? Or maybe it should just be removed entirely and the one or two blocks that use it be re-imagined to use images directly?
The text was updated successfully, but these errors were encountered:
The
SpecreduceOperation
class has as its superclass_ImageParser
. That seems to do nothing other than offering a_parse_image
method, which notable coerces Everything into a Spectrum1D object (specreduce/specreduce/core.py
Lines 78 to 79 in ddb0f7b
In a spectroscopic workshop last week, several people were confused by this given that most of the operations illustrated here: #71 do not take in an image and output a spectrum1D. Many instead take in or output spectrumcollection, or take in spectrum1d, etc.
It's actually unclear to me why this class even exists. It seems to do a very specific parsing operation that's used a couple different places but very confusingly - e.g. an "image" is converted into a spectrum1D but then set to be an image, whereas an image really should be an image class (i.e., a
CCDImage
) unless it has a meaningful wavelength solution.It's possible this is all just an oversight, as that particular code hasn't been touched in like a year or more even as other things were implemented. It might be the straightforward fix is to remove the subclass and instead implement this as some kind of utility function? Or maybe it should just be removed entirely and the one or two blocks that use it be re-imagined to use images directly?
The text was updated successfully, but these errors were encountered: