Code

Refactor reference file loading#233

Code

Merged

hpparvi merged 16 commits intoastropy:mainastropy/specreduce:mainfrom hpparvi:issue_169_fixhpparvi/specreduce:issue_169_fixCopy head branch name to clipboardDec 16, 2024

+92-183

Commits

Commits on Nov 17, 2024

• Refactored data file access to use get_pkg_data_filename instead of self-written wrappers around download_data.

  hpparvi

  committed
  95f666a

Commits on Nov 18, 2024

• Updated data retrieval in calibration_data.py to use get_pkg_data_fileobj and get_pkg_data_filename and translate URLError errors into warnings.

  hpparvi

  committed
  ab920e5

• Added a missing blank line.

  hpparvi

  committed
  714dc6c

• Removed test_get_reference_file_path.py.

  hpparvi

  committed
  e775f39

Commits on Nov 28, 2024

• - Cleaned up the code dealing with downloading data files in calibration_data.

  Show description for db5d5ad
  hpparvi

  committed
  db5d5ad

Commits on Nov 29, 2024

• Improved calibration_data test coverage.

  hpparvi

  committed
  6731847

• Fixed codestyle errors in calibration_data and its tests.

  hpparvi

  committed
  ffde805

• Trying to figure out why some tests suddenly fail in Python 3.11.

  hpparvi

  committed
  cedb9af

• Still trying to figure out why some tests suddenly fail in Python 3.11.

  hpparvi

  committed
  b80551b

• Ignoring 'pytest.PytestUnraisableExceptionWarning' warnings that are raised for "test_make_2d_arc_pass_wcs" and "test_load_onedstds" on Python 3.11.

  hpparvi

  committed
  3b87c60

• Fixed code style for the changed tests.

  hpparvi

  committed
  1c4ae4a

Commits on Dec 1, 2024

• Commented out the PytestUnraisableExceptionWarning filters. Better to find the reason why they happen in Python 3.11 rather than just to ignore them.

  hpparvi

  committed
  86f3d95

• - Changed back to use download_file instead of the get_pkg_* functions. This leads to more readable and cleaner code in the end.

  Show description for 0733319
  hpparvi

  committed
  0733319

• - Ignoring "ResourceWarning"s in pytest config. These were raised in Python 3.11 for tests that tried to download a nonexistent file even when the URLError was caught correctly.

  hpparvi

  committed
  4a5a494

• Removed a forgotten warning filter.

  hpparvi

  committed
  6194916

• Fixed code style errors.

  hpparvi

  committed
  9aecda5