Fix for gwcs inverse transform with a bounding_box #1204
Closed
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a test where the input passed to the inverse transform is out of bounds. It should be merged after gwcs#498.
More specifically the footprint defined by the test WCS is [1, 49]*u.nm.
The input passed is in GHz and well outside this footprint. As a result the Tabular model in the WCS errors with "out of bounds" . This PR adjust the input values to be within the footprint.
As a side note, I found it is best to define Tabular model with
bounds_error=False, fill_value=np.nan
. In this case an error is not raised and the value returned when out of bounds is NaN which is more in line with the WCS philosophy.