-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added modules for transfering groups to the server #216
base: master
Are you sure you want to change the base?
Conversation
One module transfers a single group. The other module transfers all groups.
Looks pretty awesome. The only thing I would suggest is maybe using a single module and deciding which units to attempt to move to the server based on where the module was dropped. So, for example if the user drops the module in empty space assume they want all units moved but if they drop it on a unit assume they want that units group moved. This keeps the number of modules lower (so less things to sort through each time you want to find a module you're interested in). Also a couple of small code-style comments: By convention the names for functions and global variables have capitals after the underscore (so All the other code uses spaces between 'if' and opening parenthesis. For example, Lastly all the '{''s belong on their own lines (except in the case of foreach):
is preferred over
https://github.com/astruyk/Ares/blob/master/src/addons/ares_zeusExtensions/scripts/Equipment_RemoveWeaponOptics.sqf has some examples of the various code blocks indentation. |
Thanks! I agree on your view on implementing it as a single module, and I'll look into it next week. |
*/ | ||
private ["_group", "_debugOn"]; | ||
_group = [_this, 0, objNull] call BIS_fnc_param; | ||
_debugOn = [_this, 1, false] call BIS_fnc_param; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason for using BIS_fnc_param
instead of params
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't aware of "params" - learned something today! Thanks!
Oh, looks like Astruyk is back in action maybe. You going to make updates to Ares? Most of us figured you abandoned Ares so people are asking if they can maintain it or take it over on your forum thread. |
FYI: There will be a little delay before I fix the scripts. My computer just had a bad trip, so I need to fix it first (replace som hardware). |
Drop the module on a group to transfer the specific group. Drop the module elsewhere to transfer all groups.
Sometimes when transfering units to the server, some units loose their gear and uniform. Other people are experiencing this as well (example here), so I guess it's a feature/bug. |
dont want to necro, but |
One module transfers a single group.
The other module transfers all groups.
Relates to issue #159