Add zip and enumerate #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thegaram
reviewed
Mar 24, 2020
src/par_stream/zip.rs
Outdated
Comment on lines
41
to
49
| fn poll_next(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> { | ||
| let this = self.project(); | ||
| let next = ready!(this.stream.poll_next(cx)); | ||
| let other_next = ready!(this.other.poll_next(cx)); | ||
| match (next, other_next) { | ||
| (Some(a), Some(b)) => Poll::Ready(Some((a, b))), | ||
| _ => Poll::Ready(None), | ||
| } | ||
| } |
There was a problem hiding this comment.
This will drop items when this.stream is ready but this.other is not. In this case, I suggest you store the result of this.stream.poll_next(cx) and use that stored value during the next poll (see here).
There was a problem hiding this comment.
A straightforward port of the above into ParallelStream requires the ParallelStream::Items to be Sync. I'm not quite sure why, I think because they aren't Fused?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add zip/enumerate. Are these implementations okay? I can add a few more if you're good with these
#2