Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to improve autoupdate #227

Closed
derberg opened this issue Apr 6, 2023 · 10 comments · Fixed by #262
Closed

Try to improve autoupdate #227

derberg opened this issue Apr 6, 2023 · 10 comments · Fixed by #262
Labels
enhancement New feature or request

Comments

@derberg
Copy link
Member

derberg commented Apr 6, 2023

Reason/Context

The autoupdate workflow doesn't work with forks.

It can update only branches that are in the upstream.

Description

When the branch from the fork is out of sync with master, in the UI maintainers see a button that they can click to update the branch with master.

We should allow anyone to be able to trigger such an update.

If there is a button, there needs to be API behind it, REST or GraphQL. There needs to be a research on how to trigger such branch update in form with an API. Then we need to update autoupdate workflow

@Shurtu-gal
Copy link
Contributor

@derberg Can I work upon this?

@derberg
Copy link
Member Author

derberg commented May 22, 2023

sure, go ahead

@Shurtu-gal
Copy link
Contributor

Shurtu-gal commented May 22, 2023

  • Should the updation of branch be automatic or manual?
  • Also anyone includes everyone or some specific group of people?
  • What should be done in case of merge conflicts?

cc - @derberg

Copy link
Member Author

derberg commented May 23, 2023

  • it should be manual, like use should pass come comment into PR, like /update
  • anyone
  • I think there is already a workflow that detects that where merge conflict is in place, and someone attempts to merge, bot drops a message about it. So basically extend this workflow to be triggered/used in case somebody do /update but it fails because of merge conflict

@Shurtu-gal
Copy link
Contributor

@derberg, can you please tell me the secrets stored in the repo so that I can introduce them into the code?

Also, the updation of forks requires a maintainer level of access, if I am not wrong. 😓

@derberg
Copy link
Member Author

derberg commented Jun 27, 2023

sorry, was out on holidays

yeah, I cannot give you secrets, this is why these are secrets 😛

Also, the updation of forks requires a maintainer level of access, if I am not wrong

yes, and our bots are maintainers in all repos, so that will work

@derberg
Copy link
Member Author

derberg commented Jun 27, 2023

you probably need to setup alternative test account to test it. I do it on my own too, have 2 GH accounts, one that you see here and the other purely for testing

@Shurtu-gal
Copy link
Contributor

Got it 😄

@derberg
Copy link
Member Author

derberg commented Apr 4, 2024

/help

@asyncapi-bot
Copy link

Hello, @derberg! 👋🏼

I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants