-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autoupdate-workflow #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure how it works, also please share examples where you tested it.
I'm confused because:
- I do not understand why autoupdate workflow had to be removed
- what is the difference between
update
andautoupdate
(cause you left autoupdate). Is it thatautoupdate
you use once and then it is always triggered, andupdate
you need to pass every time you wanna trigger update? - in short explain why previous action did not work and what technical change you do in your action that now bot token will be able to push to fork
@derberg as was discussed over slack, to not consume too much action minutes right now auto-update is only enabled for comments like Labels were meant for filtering in case of mass updates, like in this case Also, I had removed the previous one as I this one was sufficient for both tasks, but before we do so we have to consider amount of action minutes it will take. Furthermore, GH API limit may also be reached. Why wasn't the previous one working?Because the API used by it requires admin access for the updation. Meanwhile, I am this mutation which basically uses a merge PR already created by GitHub (Yeah, I know it sounds unreal 😆), and applies it on top of the HEAD, this was custom made for PR branches. |
the problem with saving minutes is that we have a huge amount of bot-created PRs, that quite often require autoupdating one example: asyncapi/asyncapi-react#924 -> by default autoupdate is added and the bot merges master in like a charm |
/help |
Hello, @Shurtu-gal! 👋🏼
|
/autoupdate |
/update |
@derberg Note that only labelled PRs are auto-updated rest have to be manually done. |
.github/workflows/automerge-for-humans-add-ready-to-merge-or-do-not-merge-label.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@Shurtu-gal I see you requested review again, but I understand you will do further refactor first right? |
@derberg The refactoring has been done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also in error messages for user, we do not write anything about merge conflicts, that in case of merge conflicts it will also not work
Added that as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff!!!
/rtm |
/help |
Hello, @Shurtu-gal! 👋🏼
|
/update |
Description
/update
comment and updates PRs pointing to it and havingautoupdate
label in it./help
to have/update
in it.Related issue(s)
Fixes #227