Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncAPI Studio automated updates broken #1117

Open
derberg opened this issue Dec 17, 2024 · 2 comments
Open

AsyncAPI Studio automated updates broken #1117

derberg opened this issue Dec 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@derberg
Copy link
Member

derberg commented Dec 17, 2024

Looks to me like https://github.com/asyncapi/studio/blob/master/apps/studio/package.json#L44 is running on very old react component version which is not good.

Its confusing people for very long, look: https://studio.asyncapi.com/?share=3469f1ef-eae6-4e23-a53c-f4d2877fd857 it still runs on version there reverts meaning of action verbs :(

So one thing is to update the component in studio, another is to automate it.

Current automation do not work: https://github.com/asyncapi/asyncapi-react/blob/master/.github/workflows/bump.yml

It is because it uses the default workflow from .github that is using default location of package.json from root, to grab package name. The workflow needs an update here or in .github but then we need to figure out, hot to overwrite default packagejson_path with custom value, like ./library. Probably environment variables.

cc @Shurtu-gal so he is aware of issues in Studio.

@derberg derberg added the bug Something isn't working label Dec 17, 2024
@derberg derberg changed the title AsyncAPI automates updates AsyncAPI Studio automated updates broken Dec 17, 2024
@derberg
Copy link
Member Author

derberg commented Dec 17, 2024

Its confusing people for very long, look: https://studio.asyncapi.com/?share=3469f1ef-eae6-4e23-a53c-f4d2877fd857 it still runs on version there reverts meaning of action verbs :(

actually it is a different weird bug. The switch of verbs happens only if reply is present. If I remove reply, the verb shows as SEND not RECEIVE

@Shurtu-gal
Copy link

I will take a look into this this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants