Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar broken in playground when preview switches to compact layout #907

Closed
rijenkii opened this issue Feb 3, 2024 · 5 comments · Fixed by #1066
Closed

Sidebar broken in playground when preview switches to compact layout #907

rijenkii opened this issue Feb 3, 2024 · 5 comments · Fixed by #1066
Labels
Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com released

Comments

@rijenkii
Copy link

rijenkii commented Feb 3, 2024

Description

When opening the sidebar through the hamburger button on bottom right of the screen, it is drawn on the right border of the screen, or not drawn at all if you decrease the space dedicated to the preview.

Reproduced on Firefox 121 and Chromium 120.0.6099.216, Fedora 39.

Steps to reproduce

Paste the following into the playground:

Schema
{
  "asyncapi": "3.0.0",
  "info": {
    "title": "Reproduction",
    "version": "1.0.0"
  },
  "operations": {
    "test": {
      "action": "receive",
      "channel": { "$ref": "#/channels/test" }
    }
  },
  "channels": {
    "test": {
      "address": "/test",
      "messages": {
        "test": { "$ref": "#/components/messages/test" }
      }
    }
  },
  "components": {
    "messages": {
      "test": {
        "payload": {
          "type": "object",
          "properties": {
            "test": {
              "description": "test",
              "type": "string",
              "pattern": "^(?:helloworld)+$"
            }
          },
          "required": ["test"]
        }
      }
    }
  }
}
Configuration
{
  "show": {
    "sidebar": true,
    "info": true,
    "operations": true,
    "servers": true,
    "messages": true,
    "schemas": true,
    "errors": true
  },
  "expand":{
    "messageExamples": false
  },
  "sidebar": {
    "showServers": "byDefault",
    "showOperations": "byDefault"
  }
}

Then click on the hamburger button.

Expected result

image

Actual result

image

Troubleshooting

I have achieved the result in the "expected result" by removing .w-full from the parent of .sidebar--content and hardcoding correct width on that element.

Copy link

github-actions bot commented Jun 3, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 3, 2024
@rijenkii
Copy link
Author

rijenkii commented Jun 3, 2024

Still an issue.

@github-actions github-actions bot removed the stale label Jun 4, 2024
@AceTheCreator AceTheCreator added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Sep 30, 2024
surajTade added a commit to surajTade/asyncapi-react that referenced this issue Oct 5, 2024
kash2104 added a commit to kash2104/asyncapi-react that referenced this issue Oct 8, 2024
@kash2104
Copy link

@rijenkii is the issue still open?

@rijenkii
Copy link
Author

The issue is still reproducible on https://asyncapi.github.io/asyncapi-react/:
image

asyncapi-bot pushed a commit that referenced this issue Nov 4, 2024
Co-authored-by: Cody's Dad <40604284+AceTheCreator@users.noreply.github.com>%0ACo-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>%0ACo-authored-by: acethecreator <devaze007@gmail.com>
@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com released
Projects
None yet
4 participants