Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom extension rendering #994
base: master
Are you sure you want to change the base?
feat: custom extension rendering #994
Changes from 5 commits
db17606
a52c230
22f07b3
18654d2
9b978b8
de451e8
13a8a6c
23401a9
6c4f19f
37bc952
3b19209
95bfa86
8492e7a
389e407
973c1da
4b03c14
3b548f5
cae5861
8caea6e
f986398
979777d
a34f50a
32cf262
c630f89
eed70c4
350646a
d91df2a
3e57a3f
1740980
361a2c2
aa7423b
8384cd8
3563ab1
df932da
a25f1d2
ec52216
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably move this to the types file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it into the types file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
deepExpand
is set but seems like an incomplete functionality. I think you should remove it if you don't see it adding any functionality to your changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. I removed
deepExpand
.