Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update list of repos owned by smoya #1113

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

smoya
Copy link
Member

@smoya smoya commented Mar 20, 2024

Description

This PR updates the list of repositories I own in the MAINTAINERS.yaml file.
Additionally, I'm removing event-gateway and infra from the list since both are gonna be moved to the archive pretty soon. See https://github.com/orgs/asyncapi/discussions/1045 and asyncapi-archived-repos/infra#62.

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@quetzalliwrites
Copy link
Member

quetzalliwrites commented Mar 25, 2024

hmmm, do you understand this error, @smoya ? 🤔 Why is it asking for a GH token?

Error: Unhandled error: Error: Input required and not supplied: github-token

@smoya
Copy link
Member Author

smoya commented Mar 25, 2024

hmmm, do you understand this error, @smoya ? 🤔 Why is it asking for a GH token?

Error: Unhandled error: Error: Input required and not supplied: github-token

Can you retry the execution of that GH action? It is complaining about the gh token missing but I don't want to believe it is missing 🫢

@quetzalliwrites
Copy link
Member

I can't, it's part of the review checks here in the PR? I don't know how that works haha : 😆

@quetzalliwrites quetzalliwrites changed the title docs: update list of repos owned by @smoya docs: update list of repos owned by smoya Mar 25, 2024
@quetzalliwrites
Copy link
Member

hey, @smoya I just removed the @ character removed from your title... i think it's possible that was causing an error?

@smoya
Copy link
Member Author

smoya commented Mar 26, 2024

hey, @smoya I just removed the @ character removed from your title... i think it's possible that was causing an error?

I wouldn't say so. Maybe a temporary error on GH side. But everything could be possible.

@smoya
Copy link
Member Author

smoya commented Mar 26, 2024

Ok, found out what is happening. I expect the script is failing at this right line: https://github.com/asyncapi/community/blob/master/.github/workflows/maintainers-tsc-changes-verification.yaml#L100

On that side, we should check why the error message is not showing up but instead this github-token stuff...

On the other side, It seems I can't modify manually this list of repos, but some other action seems to be reading from each CODEOWNERS file in each repo when modified, and automatically updates this.
I guess since I didn't become owner of any new repo since the creation of the script, an update to the list of repos I own was never triggered.
The question is... how can we manually trigger such an update 🤔

cc @14Richa @derberg

@derberg
Copy link
Member

derberg commented Apr 2, 2024

yeah, this is not yet completed, this is why this workflow is not required at the moment, so you can merge without worries

@derberg
Copy link
Member

derberg commented Apr 2, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit c0fa939 into asyncapi:master Apr 2, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants