Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add slack ID of all members #617

Closed
wants to merge 10 commits into from
Closed

feat: add slack ID of all members #617

wants to merge 10 commits into from

Conversation

sambhavgupta0705
Copy link
Member

Description

Related issue(s)

resolves #606

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sambhavgupta0705
Copy link
Member Author

sambhavgupta0705 commented Feb 26, 2023

cc : @KhudaDad414 @derberg
I don't know what to add in description apart from that everything is fixed

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR!!!
added small comments regarding schema

Comment on lines 58 to 66
"slack":{
"type":"string",
"description": "It must be a valid slackID. It is the ID of the slack of the person 's profile",
"examples":[
"U01QPAP1QWE"
]

},

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"slack":{
"type":"string",
"description": "It must be a valid slackID. It is the ID of the slack of the person 's profile",
"examples":[
"U01QPAP1QWE"
]
},
"slack": {
"type": "string",
"description": "It must be a valid slackID. It is the ID of the person in the AsyncAPI Slack workspace.",
"examples": [
"U01QPAP1QWE"
]
},

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this field, to be useful, should be also added to line 79 to list of required fields

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derberg should I add slackID there also?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean slack property should be mandatory in TSC members list. To enforce it, add it to line 79 in the schema, to the list of required props

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ,doing the same

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sambhavgupta0705 we have a new TSC member added to list -> Barbaño González

please add her slack id too 🙏🏼

@sambhavgupta0705
Copy link
Member Author

@sambhavgupta0705 we have a new TSC member added to list -> Barbaño González

please add her slack id too 🙏🏼

ok

@sambhavgupta0705
Copy link
Member Author

@derberg can I get the details of Barbaño González such as available for hire and repos she is maintaining.

@quetzalliwrites
Copy link
Member

@Barbanio what repos do you maintain again? 🤔 Is it community and training only? Or ..?

@quetzalliwrites
Copy link
Member

@derberg can I get the details of Barbaño González such as available for hire and repos she is maintaining.

She works at Postman with us 😄

@Barbanio
Copy link
Contributor

Barbanio commented Mar 2, 2023

Hello @sambhavgupta0705! Yes, I'm a maintainer in the community and training repositories.

@derberg
Copy link
Member

derberg commented Mar 2, 2023

@sambhavgupta0705 but you did not have to add @Barbanio as she was there already, just slackID was missing 😄 Now when you added you have conflicts with what is in master 😄

@derberg
Copy link
Member

derberg commented Mar 2, 2023

This was already in master

	{
		"name": "Barbaño González",
		"linkedin": "barbano-gonzalez-moreno",
		"twitter": "BarbanoGonzalez",
		"github":"Barbanio",
		"availableForHire": false,
		"company": "Postman",
		"repos": [
			 "training",
			 "community"
		]
	}

@sambhavgupta0705
Copy link
Member Author

sambhavgupta0705 commented Mar 2, 2023

@derberg can you help me I think other changes of master are also reflected here:(

I did git pull and git merge master which did this menace:((

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry mate but the only solution I see:

  • copy changes you did in TSC_MEMBERS.json to your pocket 😄
  • close this PR
  • open new PR with new branch, cut from latest master
  • paste changes from the pocket 😄

I really do not have a better solution, sorry

@sambhavgupta0705
Copy link
Member Author

ok doing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store slack memberID of TSC members
4 participants