ci: verify changes to Maintainers.yaml made by the bot

[14Richa]

Description

This pull request includes a workflow triggered when changes are made to the Maintainers.yaml file. It checks for new maintainer objects, removes maintainer objects, and modifies GitHub usernames and repository lists.

This workflow has 3 jobs:

• verify-changes: This job compares changes in the MAINTAINERS.yaml file between the main branch and the pull request, identifies removed TSC members by the asyncapi-bot, and checks for critical changes made by humans.

• handle-human-made-critical-changes: If there are critical changes detected in the MAINTAINERS.yaml file, this job posts a comment on the pull request with the error messages and closes the pull request.

• bot-removal-notification: This job notifies maintainers when the asyncapi-bot removes a TSCmember from the MAINTAINERS.yaml file by posting a comment on the pull request.

I have tested the workflow in my testRepo you can find the logs : https://github.com/14Richa/testRepo/actions/runs/5750090267

Note that the Maintainers.yaml file is expected to be in a separate #720 that has not yet been merged.

Related issue(s)
#210

[derberg]

I see you prefer bash over js 😄

• why do we need two POST calls? call to reviews endpoint should be enough, no?
• it is not such simple validation of the actor. We discussed that there is a case for human edit, when people want to update some information about them, like linkedin, or company affiliation for example. So validation should block PR from merging only if human creates a PR that adds or remove new maintainer object imho

[derberg]

I see PR title verify changes to Maintainers.yaml made by the bot but no code that verifies that changes are made by bot. Can't review as not sure what is the context an cannot understand why bot cannot remove maintainer and that PR is closed

[14Richa]

I see PR title verify changes to Maintainers.yaml made by the bot but no code that verifies that changes are made by bot.

Thank you @derberg for pointing this out. It was an oversight, and I've now added the check to verify if changes are made by the bot.

[14Richa]

@14Richa left some comments, please also update description with latest tests as it is pointing to old logs I think

Thanks for the review. I have updated the description with recent logs.

[KhudaDad414]

one small thing, other than that, looks great!

[14Richa]

one small thing, other than that, looks great!

Thanks @KhudaDad414, I have made the requested changes.

[KhudaDad414]

LGTM!

[derberg]

shouldn't this fail 14Richa/testRepo#417 ?

[14Richa]

shouldn't this fail 14Richa/testRepo#417 ?

Yep @derberg. I have made minor fixes. Now it's working fine. You can take a look here : 14Richa/testRepo#420

[derberg]

👏🏼

[derberg]

/dnm

making sure it won't get merged by any automation to early

[derberg]

lgtm

[derberg]

/rtm