-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: updates the isTscMember
property and manages changes in the tsc_members
teams
#807
Merged
asyncapi-bot
merged 24 commits into
asyncapi:master
from
14Richa:14Rich/update-tsc-workflow
Aug 3, 2023
Merged
ci: updates the isTscMember
property and manages changes in the tsc_members
teams
#807
asyncapi-bot
merged 24 commits into
asyncapi:master
from
14Richa:14Rich/update-tsc-workflow
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14Richa
requested review from
fmvilas,
quetzalliwrites,
derberg,
asyncapi-bot-eve and
thulieblack
as code owners
July 26, 2023 10:12
derberg
requested changes
Jul 26, 2023
derberg
reviewed
Jul 31, 2023
KhudaDad414
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just one small suggestion. 👍
derberg
approved these changes
Jul 31, 2023
derberg
approved these changes
Aug 3, 2023
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a workflow named
TSC Management Workflow
which manages changes to the tsc_members team. The workflow is automatically triggered when a pull request is merged, and it specifically detects changes in the 'MAINTAINERS.yaml' file. It consists of several jobs that run sequentially to detect changes, update the TSC team, notify the community, and maintain the Emeritus list.detect_tsc_membership_changes
: Compares MAINTAINERS.yaml between the main branch and pull request to detect TSC member changes.add_tsc_member
: Adds new TSC members to thetsc_members
teams.display_message
: Filters new TSC members and posts a welcome message to them on the pull request.remove_tsc_member
: Removes specified TSC members from thetsc_members
teams.remove_tsc_goodbye
: Posts a farewell message to removed TSC members on the pull request.update_emeritus
: UpdatesEmeritus.yaml
with the latest TSC member list and creates a pull request for the changes.Testing and Logs:
This workflow has been thoroughly tested in my TestRepo. The test logs for scenarios when adding and removing TSC members can be accessed below: