-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dropdown and the contents of the dropdown section #347
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@sbsangu, Thanks for opening the PR. I'll have to hold on reviewing the PR cuz the discussion in the issue doesn't seem to be resolved yet |
@AceTheCreator Does the discussion in the issue is resolved now? |
Not yet, still waiting for @Mayaleeeee comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @sbsangu Thank you!
@sbsangu,two things.
|
Hey @AceTheCreator |
@AceTheCreator @Mayaleeeee Do i need to change anything? |
Sorry, what behaviour @Mayaleeeee? |
I mean what's your reason for not supporting the changes. @AceTheCreator |
I do support the changes, i'm only suggesting enhancements :/ If you think it's looks good, we are good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you resolve the conflict?
cc : @sbsangu |
I guess we should close this pr @AceTheCreator @thulieblack |
Description
Fixes #345