Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown and the contents of the dropdown section #347

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sbsangu
Copy link

@sbsangu sbsangu commented Jul 17, 2024

Description

  • Bug Description: The dropdown icon does not show, and the 'All' text is aligned to the left side and the dropdown is not working properly.
  • Expected Behavior: The dropdown icon should be shown, and the inner content of the button should be centered and the dropdown should work as expected.
  • Fix Implemented:
    • Added missing dropdown icon to the button.
    • Centered the text inside the button to align properly.
    • Fixed the dropdown functionality.

Screenshot 2024-07-18 013654

Fixes #345

Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 4a023c9
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/66d9a47b07e5b300083cd0e6
😎 Deploy Preview https://deploy-preview-347--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@AceTheCreator
Copy link
Member

@sbsangu, Thanks for opening the PR. I'll have to hold on reviewing the PR cuz the discussion in the issue doesn't seem to be resolved yet

@sbsangu
Copy link
Author

sbsangu commented Jul 30, 2024

@AceTheCreator Does the discussion in the issue is resolved now?

@AceTheCreator
Copy link
Member

Not yet, still waiting for @Mayaleeeee comments.

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @sbsangu Thank you!

cc @AceTheCreator @ashmit-coder

@AceTheCreator
Copy link
Member

@sbsangu,two things.

  • You don't have to make the dropdown border-radius that curved.
  • Dropdown doesn't close when i click out.

@Mayaleeeee
Copy link
Member

@sbsangu,two things.

  • You don't have to make the dropdown border-radius that curved.
  • Dropdown doesn't close when i click out.

Hey @AceTheCreator
Typically, dropdowns can close when clicking outside. It keeps the UI clean and reduces user confusion. I'm curious, though, what's your reason for not supporting that behaviour? I'd love to understand your perspective.

@sbsangu
Copy link
Author

sbsangu commented Sep 2, 2024

@AceTheCreator @Mayaleeeee Do i need to change anything?

@AceTheCreator
Copy link
Member

@sbsangu,two things.

  • You don't have to make the dropdown border-radius that curved.
  • Dropdown doesn't close when i click out.

Hey @AceTheCreator Typically, dropdowns can close when clicking outside. It keeps the UI clean and reduces user confusion. I'm curious, though, what's your reason for not supporting that behaviour? I'd love to understand your perspective.

Sorry, what behaviour @Mayaleeeee?

@Mayaleeeee
Copy link
Member

@sbsangu,two things.

  • You don't have to make the dropdown border-radius that curved.
  • Dropdown doesn't close when i click out.

Hey @AceTheCreator Typically, dropdowns can close when clicking outside. It keeps the UI clean and reduces user confusion. I'm curious, though, what's your reason for not supporting that behaviour? I'd love to understand your perspective.

Sorry, what behaviour @Mayaleeeee?

I mean what's your reason for not supporting the changes. @AceTheCreator

@AceTheCreator
Copy link
Member

@sbsangu,two things.

  • You don't have to make the dropdown border-radius that curved.
  • Dropdown doesn't close when i click out.

Hey @AceTheCreator Typically, dropdowns can close when clicking outside. It keeps the UI clean and reduces user confusion. I'm curious, though, what's your reason for not supporting that behaviour? I'd love to understand your perspective.

Sorry, what behaviour @Mayaleeeee?

I mean what's your reason for not supporting the changes. @AceTheCreator

I do support the changes, i'm only suggesting enhancements :/ If you think it's looks good, we are good to go.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve the conflict?

@ashmit-coder
Copy link
Collaborator

cc : @sbsangu

@ashmit-coder
Copy link
Collaborator

ashmit-coder commented Nov 10, 2024

I guess we should close this pr @AceTheCreator @thulieblack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <In the Dropdown section, contents are not perfectly aligned in the mobile view>
4 participants