-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gallery section to aacot'24 conference website #412
base: master
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for peaceful-ramanujan-288045 failed.Built without sensitive environment variables
|
@techmannih await for @Mayaleeeee to review the design at first and don't ping reviewers in the pr info. Secondly please only ping for a single issue once. |
okay got it, thank you! |
@ashmit-coder please review design |
@techmannih please be patient when it comes to PR reviewing. Once you work on a PR allow at least week before reminding the reviewers either here or on Slack |
Hey @techmannih reviewing of the design is done by @Mayaleeeee and @thulieblack so lets wait for them to get back to you! |
@techmannih create a new page container for the gallery section The browse all should direct to that page where all the images are hosted |
Lastly the events gallery should be the last section on the landing page after tickets |
@thulieblack I have added, please review this |
That does not look good in my opinion @techmannih , try to find a way to make it more suitable maybe. any ideas @thulieblack @AceTheCreator ? |
@ashmit-coder please suggest design |
Thats not my area of expertise 😅 but I will suggest something for sure if I think of anything! |
@techmannih i think you should merge past event under resources hub |
@thulieblack @AceTheCreator please check |
@Mayaleeeee, is this how the gallery design should look? |
This one? |
@thulieblack @AceTheCreator @Mayaleeeee please review this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @techmannih |
Please provide the other images for this design |
Hey @Mayaleeeee could you assist @techmannih with the design over here, he seems to be lost. |
Also @techmannih resolve the conflicts. |
Sure @ashmit-coder |
cc: @Mayaleeeee |
@techmannih please resolve the conflict so we can review |
What design, please? |
I thought I would resolve the conflicts in another next commit. |
close #264
Issue #264
Related issue(s)
Issue #264
@ashmit-coder @Mayaleeeee please review this PR and merge it.