fix: resolved lint warnings #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SahilDahekar
requested review from
AceTheCreator,
thulieblack,
Mayaleeeee and
ashmit-coder
as code owners
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AceTheCreator
requested changes
Nov 13, 2024
|
Hey @AceTheCreator , here are before and after images :- Before : After : |
|
@ashmit-coder your review is needed :) |
Hey @AceTheCreator waiting for this pr #386 So that the tests are ran on this pr, just to be sure all functionalities are working. |
|
Hey @ashmit-coder , since PR #386 is merged can we proceed with this PR. |
Sure! Soon |
ashmit-coder
approved these changes
Nov 27, 2024
|
hey @AceTheCreator ptal |
|
@SahilDahekar could you confirm that there are no further warnings after the updation to the code. |
|
No lint warnings @ashmit-coder |
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stepThree.js&select.jsfiles.Related issue(s)
Fixes #328