Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: minor fix in update docs workflow #1267

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

DhairyaMajmudar
Copy link
Contributor

Description
Fixed the path to generator docs at line 42

Related issue(s)
related to #1264 (comment)

Copy link

changeset-bot bot commented Sep 9, 2024

⚠️ No Changeset found

Latest commit: 174e764

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DhairyaMajmudar
Copy link
Contributor Author

cc: @derberg

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also add another path to paths list in line 7

.github/workflows/update-docs-in-website.yml

so the workflow runs not only when docs are changed but also when workflow is updated?

@DhairyaMajmudar
Copy link
Contributor Author

can you please also add another path to paths list in line 7

.github/workflows/update-docs-in-website.yml

so the workflow runs not only when docs are changed but also when workflow is updated?

Sure thingy, I've updated my PR : )

Copy link

sonarcloud bot commented Sep 9, 2024

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@derberg
Copy link
Member

derberg commented Sep 10, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 60a788d into asyncapi:master Sep 10, 2024
12 checks passed
@DhairyaMajmudar DhairyaMajmudar deleted the workflow-fix branch September 10, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants