Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use optional chaining in template validator #1300

Merged

Conversation

thebedigupta
Copy link
Contributor

Description
In this PR I worked on this issue
captured test results test-results.md

Resolved

  • Slightly improving readability
  • Following modern JavaScript best practices

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: e0b7a7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

sonarcloud bot commented Oct 10, 2024

Copy link
Collaborator

@Gmin2 Gmin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derberg derberg changed the title refactor: using optional chaining refactor: use optional chaining in template validator Oct 14, 2024
@derberg
Copy link
Member

derberg commented Oct 14, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 0e3478b into asyncapi:master Oct 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants