Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify generateFile function with optional chaining expression #1306

Merged
merged 2 commits into from
Oct 21, 2024
Merged

refactor: simplify generateFile function with optional chaining expression #1306

merged 2 commits into from
Oct 21, 2024

Conversation

D-I-R-M
Copy link
Contributor

@D-I-R-M D-I-R-M commented Oct 18, 2024

Description

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c4c5da5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot]
github-actions bot reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

ItshMoh
ItshMoh approved these changes Oct 19, 2024
View reviewed changes
Copy link

@ItshMoh ItshMoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derberg derberg changed the title refactor: simplify the function using optional chaining expression refactor: simplify generateFile function with optional chaining expression Oct 21, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@derberg
Copy link
Member

derberg commented Oct 21, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit aa79245 into asyncapi:master Oct 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@derberg derberg derberg approved these changes

@ItshMoh ItshMoh ItshMoh approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D-I-R-M @derberg @ItshMoh @asyncapi-bot