-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add the development guide on how to run test #1250
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we have a release process described in readme, don't you want dev guide to be there too?
I think that for consistency, we should have both either in main readme, or both just mentioned in readme and details in separate markdown files
@lmgyuan thoughts on this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left 2 comments
what we are missing additionally is explanation on how to manually test templates features using react-template + you could fix template config in this PR, the version prop
Development.md
Outdated
|
||
### Adding tests | ||
|
||
1. Create new test files in the appropriate directory under `test/`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test is no longer in root
@lmgyuan and i had a conversation and we both agreed to maake a seperate |
The connfig with the version of different templates right? how do you want the content to be, like pointing to this docs (https://www.asyncapi.com/docs/tools/generator/versioning) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gmin2 ok then, please move release process part from readme to development.md
also please update https://github.com/asyncapi/generator/blob/master/apps/generator/test/test-templates/react-template/package.json#L10 so it is apiVersion
and not api
@Gmin2 you did not move |
Quality Gate passedIssues Measures |
/rtm |
Description
Added a guide on how to run test locally and in isolated docker enviorment.
Related issue(s)
Fixes #1248