Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use optional chaining in template params validation #1299

Merged
merged 2 commits into from
Oct 14, 2024
Merged

refactor: use optional chaining in template params validation #1299

merged 2 commits into from
Oct 14, 2024

Conversation

thebedigupta
Copy link
Contributor

Description
In this PR I worked on this issue
captured test results test-results.md

Resolve

  • Simplified Null Check
  • Maintained functionality

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 12b47c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Gmin2

This comment was marked as off-topic.

Sign in to view

Gmin2
Gmin2 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@Gmin2 Gmin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@derberg derberg changed the title refactor: use optional chaining for improved readability refactor: use optional chaining in template params validation Oct 14, 2024
@derberg
Copy link
Member

derberg commented Oct 14, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 254b072 into asyncapi:master Oct 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gmin2 Gmin2 Gmin2 approved these changes

@derberg derberg derberg approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebedigupta @derberg @Gmin2 @asyncapi-bot