Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send messages to the address of the channel #737

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: send messages to the address of the channel #737

merged 1 commit into from
Mar 15, 2024

Conversation

KhudaDad414
Copy link
Member

@KhudaDad414 KhudaDad414 commented Mar 12, 2024 •
edited
Loading

Description

  • fix the bug when Glee sends the message to the channel name instead of the channel address in MQTT.
  • show a warning when the channel name is invalid when we send a message.
  • show a warning when there is no send operation defined in the AsyncAPI file.

Related issue(s)
fixes #721

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8250082675

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.884%
Totals Coverage Status
Change from base Build 8239916406: 0.0%
Covered Lines: 388
Relevant Lines: 483
💛 - Coveralls

Souvikns
Souvikns approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@KhudaDad414
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 6b12c62 into asyncapi:master Mar 15, 2024
26 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.35.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Souvikns Souvikns Souvikns approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MQTT channel seems to be using wrong topic when sending message
4 participants
@KhudaDad414 @coveralls @asyncapi-bot @Souvikns