Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to parser API v3 #461

Closed
wants to merge 2 commits into from

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Nov 16, 2023

Description
This PR updates the template to use the newest parser API v3.

Related issue(s)
Blocked by asyncapi/generator#1066
Blocked by asyncapi/cli#908
Related to #456

@jonaslagoni jonaslagoni marked this pull request as draft November 16, 2023 22:41
@fmvilas fmvilas marked this pull request as ready for review November 29, 2023 11:56
@fmvilas
Copy link
Member

fmvilas commented Nov 29, 2023

Blockers are not blocking anymore :)

Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized tests are failing. Other than that, looks good to me.

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Nov 29, 2023

Merging changes here together with #459

@jonaslagoni jonaslagoni deleted the update_parser_api branch November 29, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants