Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: problem with json serializer option with C# generator #1477

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

JFCote
Copy link
Contributor

@JFCote JFCote commented Aug 15, 2023

Description

  • Fix generation problem at 2 places when using C# generator with json serializer option
  • Missing "s" for a class
  • Missing "value." when deserializing.

@JFCote JFCote changed the title fix: Fix problem with json serializer option with C# generator fix: fix problem with json serializer option with C# generator Aug 15, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5870359342

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.194%

Totals Coverage Status
Change from base Build 5829889931: 0.0%
Covered Lines: 5261
Relevant Lines: 5564

💛 - Coveralls

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit f20e12b
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/64dbcbe11e18cd00089401fb
😎 Deploy Preview https://deploy-preview-1477--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JFCote
Copy link
Contributor Author

JFCote commented Aug 15, 2023

@jonaslagoni Please note that this will only fix the compilation. I tried the fixed code and it crash with exception at runtime. But that is another story and I don't think I have currently the knowledge to fix it myself.

@jonaslagoni
Copy link
Member

jonaslagoni commented Aug 15, 2023

What problems are you facing @JFCote? or exceptions?

@jonaslagoni jonaslagoni changed the title fix: fix problem with json serializer option with C# generator fix: problem with json serializer option with C# generator Aug 15, 2023
@jonaslagoni jonaslagoni merged commit 9b6bf34 into asyncapi:master Aug 15, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants