Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade AnyModel error to a warning (#1561) #1562

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

PeteAudinate
Copy link
Contributor

Downgrade AnyModel error to a warning

This is needed to prevent the asyncapi CLI from aborting when an AnyModel is encountered.

Related issue(s)
Resolves #1561.

This is needed to prevent the asyncapi CLI from aborting when an
AnyModel is encountered.
@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit a4a3a26
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/652d07c6810e08000877d4e9
😎 Deploy Preview https://deploy-preview-1562--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PeteAudinate, that was quick 💪

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6531921510

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.231%

Totals Coverage Status
Change from base Build 6454543708: 0.0%
Covered Lines: 5276
Relevant Lines: 5578

💛 - Coveralls

@jonaslagoni jonaslagoni merged commit d612c76 into asyncapi:master Oct 16, 2023
24 checks passed
@jonaslagoni
Copy link
Member

@all-contributors please add @PeteAudinate for code

@allcontributors
Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @PeteAudinate! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@PeteAudinate PeteAudinate deleted the anymodel-warning branch October 16, 2023 15:46
@PeteAudinate
Copy link
Contributor Author

No worries, thanks for your quick responses!

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asyncapi CLI model generation fails if AnyModel is used
4 participants