feat: add file path as input #1601

nilkanth987 · 2023-11-13T09:29:45Z

Description

Added inputProcessor option in the AbstractGenerator with type enum param
This option will allow users to pass how to process input to generators
Added file option in input type to allow user to pass file path as input to any generator
Changed input type in generateToFiles method in AbstractFileGenerator to any for handling any type of input
Looking for some input so I can improve the error logging
Also need to know what are the different types of inputs so I can add them in InputTypes enum and handle them.
NOTE: Documentation update is pending

Related issue(s)
Resolves #1591

netlify · 2023-11-13T09:29:51Z

✅ Deploy Preview for modelina canceled.

Name	Link
🔨 Latest commit	`4531288`
🔍 Latest deploy log	https://app.netlify.com/sites/modelina/deploys/655e5b55d063ee000859ad2f

github-actions

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

jonaslagoni

Thanks for taking the time to do this @nilkanth987 🙏 Got a few things that are needed to change 🙂

src/generators/AbstractGenerator.ts

test/generators/testasyncapi.yml

…om-file-2

jonaslagoni

You have some linting issues that make it hard to review the PR 🙂

nilkanth987 · 2023-11-16T06:00:17Z

@jonaslagoni , Fixed linting issues. Also do I have to use new Parser for fromFile method? It does not accept the newParser.

jonaslagoni · 2023-11-16T19:00:18Z

@jonaslagoni , Fixed linting issues. Also do I have to use new Parser for fromFile method? It does not accept the newParser.

Let me check 🙂

jonaslagoni · 2023-11-17T02:12:33Z

@nilkanth987 when you say new parser what do you mean?

nilkanth987 · 2023-11-17T03:57:29Z

@jonaslagoni , This is the new parser added in next branch that I was referring to.

modelina/src/processors/AsyncAPIInputProcessor.ts

Line 18 in ef56f3e

import { NewParser } from '@smoya/multi-parser';

jonaslagoni · 2023-11-17T06:03:55Z

@nilkanth987 its not a new parser just a bundler that can convert between multiple implementations.

Just keep what you have 👍

jonaslagoni · 2023-11-17T06:04:02Z

@nilkanth987 its not a new parser just a bundler that can convert between multiple implementations.

Just keep what you have 👍

nilkanth987 · 2023-11-17T06:05:34Z

@jonaslagoni , If everything looks good then should I write documentation for the changes done in PR?

jonaslagoni · 2023-11-18T21:33:28Z

@jonaslagoni , If everything looks good then should I write documentation for the changes done in PR?

Yes, add an example and documentation for the feature 👌

Also make sure you fix the linting problem the CI complains about 🙂

nilkanth987 · 2023-11-19T06:17:54Z

@jonaslagoni , Added example. Let me know if any issue. Merge it if everything looks good. 🙂

src/generators/AbstractFileGenerator.ts

jonaslagoni · 2023-11-20T17:47:14Z

@nilkanth987 you still have a failing check: https://github.com/asyncapi/modelina/actions/runs/6918808106/job/18831710393?pr=1601

nilkanth987 · 2023-11-21T13:19:01Z

@jonaslagoni , Fixed

examples/file-uri-input/package.json

sonarqubecloud · 2023-11-22T19:50:37Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

jonaslagoni

Nice persistence @nilkanth987! 🔥

jonaslagoni · 2023-11-22T19:54:33Z

/rtm

jonaslagoni · 2023-11-22T20:06:18Z

@all-contributors please add @nilkanth987 for code, test, example, docs

allcontributors · 2023-11-22T20:06:28Z

@jonaslagoni

I've put up a pull request to add @nilkanth987! 🎉

asyncapi-bot · 2023-11-22T20:18:58Z

🎉 This PR is included in version 3.0.0-next.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

* feat!: convert to use multi parser (#1587) * feat!: adds support for duration in java (#1604) * feat: enable AsyncAPI v3 (#1600) * fix!: add csharp support for DateTime, TimeSpan, Guid (#1612) * feat!: adds extend in common, meta, and constrained models (#1613) * feat!: adds inheritance with interfaces for java (#1593) * chore: remove duplicate version entry for AsyncAPI processor (#1609) * feat!: render python union in pydantic in the pre 3.10 way (#1626) * feat: add file path as input (#1601) * feat!: add options as parameter to constraints (#1667) * fix: (un)marshalling tuple and dictionary unwrapping for Typescript (#1717) * fix: jsonbinpack preset and runtime tests (#1718) * chore: fix linting * chore: remove unused directory * feat!: add useJavascriptReservedKeywords option for TS (#1727) * feat: enable raw properties for interface (#1729) * fix: newtonsoft could not handle enum values (#1731) * chore: update Java runtime tests (#1739) * fix: edge case where references was incorrect handled for JSON Schema (#1754) * fix: recursion bug for get nearest dependencies (#1757) --------- Co-authored-by: Kenneth Aasan <k.aasan@sportradar.com> Co-authored-by: jano-petras <jano.petras@gmail.com> Co-authored-by: Nilkanth Parmar <parmarnilkanth@gmail.com>

asyncapi-bot · 2024-02-13T12:26:56Z

🎉 This PR is included in version 4.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat: added file path as input

e781736

nilkanth987 requested review from magicmatatjahu, jonaslagoni, kennethaasan and asyncapi-bot-eve as code owners November 13, 2023 09:29

github-actions bot reviewed Nov 13, 2023

View reviewed changes

nilkanth987 changed the base branch from master to next November 13, 2023 09:41

jonaslagoni requested changes Nov 13, 2023

View reviewed changes

src/generators/AbstractGenerator.ts Outdated Show resolved Hide resolved

src/generators/AbstractGenerator.ts Outdated Show resolved Hide resolved

src/generators/AbstractGenerator.ts Outdated Show resolved Hide resolved

TRohit20 suggested changes Nov 14, 2023

View reviewed changes

test/generators/testasyncapi.yml Outdated Show resolved Hide resolved

nilkanth987 added 4 commits November 14, 2023 18:31

chore: added file input in processor

82214e2

feat: file path to file uri

4a0e482

Merge remote-tracking branch 'upstream/next' into feature/generate-fr…

86fa23a

…om-file-2

fix: parser in file input

85fa99a

jonaslagoni requested changes Nov 16, 2023

View reviewed changes

fix: lint fixed

21384b6

nilkanth987 added 2 commits November 19, 2023 11:21

chore: changed type for input to any

693b25e

docs: added example and docs

0268121

nilkanth987 requested review from Ferror, leigh-johnson and Samridhi-98 as code owners November 19, 2023 06:16

Ferror reviewed Nov 19, 2023

View reviewed changes

src/generators/AbstractFileGenerator.ts Show resolved Hide resolved

fix: lint issue fixed

653439e

jonaslagoni reviewed Nov 22, 2023

View reviewed changes

examples/file-uri-input/package.json Outdated Show resolved Hide resolved

Update examples/file-uri-input/package.json

4531288

jonaslagoni approved these changes Nov 22, 2023

View reviewed changes

asyncapi-bot added the ready-to-merge label Nov 22, 2023

jonaslagoni changed the title ~~feat: added file path as input~~ feat: add file path as input Nov 22, 2023

jonaslagoni merged commit 268bfd4 into asyncapi:next Nov 22, 2023
24 of 27 checks passed

asyncapi-bot removed the ready-to-merge label Nov 22, 2023

allcontributors bot mentioned this pull request Nov 22, 2023

docs: add nilkanth987 as a contributor for code, test, and 2 more #1629

Merged

asyncapi-bot added the released on @next label Nov 22, 2023

jonaslagoni mentioned this pull request Nov 23, 2023

Enable file input #171

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add file path as input #1601

feat: add file path as input #1601

nilkanth987 commented Nov 13, 2023 •

edited

Loading

netlify bot commented Nov 13, 2023 •

edited

Loading

github-actions bot left a comment

jonaslagoni left a comment

jonaslagoni left a comment

nilkanth987 commented Nov 16, 2023

jonaslagoni commented Nov 16, 2023

jonaslagoni commented Nov 17, 2023

nilkanth987 commented Nov 17, 2023

jonaslagoni commented Nov 17, 2023

jonaslagoni commented Nov 17, 2023

nilkanth987 commented Nov 17, 2023

jonaslagoni commented Nov 18, 2023

nilkanth987 commented Nov 19, 2023

jonaslagoni commented Nov 20, 2023

nilkanth987 commented Nov 21, 2023

sonarqubecloud bot commented Nov 22, 2023

jonaslagoni left a comment

jonaslagoni commented Nov 22, 2023

jonaslagoni commented Nov 22, 2023

allcontributors bot commented Nov 22, 2023

asyncapi-bot commented Nov 22, 2023

asyncapi-bot commented Feb 13, 2024

feat: add file path as input #1601

feat: add file path as input #1601

Conversation

nilkanth987 commented Nov 13, 2023 • edited Loading

netlify bot commented Nov 13, 2023 • edited Loading

✅ Deploy Preview for modelina canceled.

github-actions bot left a comment

Choose a reason for hiding this comment

jonaslagoni left a comment

Choose a reason for hiding this comment

jonaslagoni left a comment

Choose a reason for hiding this comment

nilkanth987 commented Nov 16, 2023

jonaslagoni commented Nov 16, 2023

jonaslagoni commented Nov 17, 2023

nilkanth987 commented Nov 17, 2023

jonaslagoni commented Nov 17, 2023

jonaslagoni commented Nov 17, 2023

nilkanth987 commented Nov 17, 2023

jonaslagoni commented Nov 18, 2023

nilkanth987 commented Nov 19, 2023

jonaslagoni commented Nov 20, 2023

nilkanth987 commented Nov 21, 2023

sonarqubecloud bot commented Nov 22, 2023

jonaslagoni left a comment

Choose a reason for hiding this comment

jonaslagoni commented Nov 22, 2023

jonaslagoni commented Nov 22, 2023

allcontributors bot commented Nov 22, 2023

asyncapi-bot commented Nov 22, 2023

asyncapi-bot commented Feb 13, 2024

nilkanth987 commented Nov 13, 2023 •

edited

Loading

netlify bot commented Nov 13, 2023 •

edited

Loading