Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed copied text UI issue #2143

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Shriya-Chauhan
Copy link
Contributor

@Shriya-Chauhan Shriya-Chauhan commented Jan 2, 2025

Description

#2142 : Isuue Number
'Copied! ' text replaced with tick icon.

Related Issue

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

image

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 84089b9
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6776d7814770bb000844e133
😎 Deploy Preview https://deploy-preview-2143--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jan 2, 2025

Pull Request Test Coverage Report for Build 12652218542

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.319%

Totals Coverage Status
Change from base Build 12264516506: 0.0%
Covered Lines: 6004
Relevant Lines: 6335

💛 - Coveralls

@Shriya-Chauhan Shriya-Chauhan changed the title fix: Bug #2142 fix: bug 2142 - Copied text UI issue fixed Jan 2, 2025
@devilkiller-ag devilkiller-ag changed the title fix: bug 2142 - Copied text UI issue fixed fix: fixed copied text UI issue Jan 6, 2025
Copy link
Member

@devilkiller-ag devilkiller-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shriya-Chauhan add the issue number in the description instead of the PR title. Also, fix the failing tests. Besides that changes looks good to me.

Copy link

sonarqubecloud bot commented Jan 7, 2025

@Shriya-Chauhan
Copy link
Contributor Author

image

I have created one file and updated one of the existing files. Can you please help me fix this issue? @devilkiller-ag

@ChaitanyaKadu03
Copy link

image

I have created one file and updated one of the existing files. Can you please help me fix this issue? @devilkiller-ag

I think this is due to the absence of C# compiler installed in the environment by default. @devilkiller-ag should we install .NET SDK? Kindly correct me!

Bellow changes can be implemented in the .github/workflows/blackbox-testing.yml ci workflow.
Setup .NET so that csc is available
name: Setup .NET
uses: actions/setup-dotnet@v3
with:
dotnet-version: '7.0.0'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants