Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reusability of schemas between versions #364

Closed
jonaslagoni opened this issue Mar 16, 2023 · 17 comments · Fixed by #468
Closed

Enable reusability of schemas between versions #364

jonaslagoni opened this issue Mar 16, 2023 · 17 comments · Fixed by #468
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers released

Comments

@jonaslagoni
Copy link
Member

jonaslagoni commented Mar 16, 2023

Reason/Context

There are specifically 2 schemas we wish to share among all versions.

  • avroSchema_v1
  • openapiSchema_3_0

To achieve this we need to do the following:

  1. Move the common schemas to a common definition folder
  2. Adapt the bundler (tools/bundler/index.js) to include these common definitions for all versions.
@jonaslagoni jonaslagoni added the enhancement New feature or request label Mar 16, 2023
This was referenced Mar 16, 2023
@achiverram28
Copy link

I would like to work on this

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Aug 11, 2023
@jonaslagoni
Copy link
Member Author

/gfi

@asyncapi-bot
Copy link
Contributor

Hey @jonaslagoni, your message doesn't follow the requirements, you can try /help.

@jonaslagoni
Copy link
Member Author

/help

@asyncapi-bot
Copy link
Contributor

Hello, @jonaslagoni! 👋🏼

I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

@jonaslagoni
Copy link
Member Author

/gfi js

@asyncapi-bot asyncapi-bot added area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Aug 11, 2023
@github-actions github-actions bot removed the stale label Aug 12, 2023
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Dec 11, 2023
@devilkiller-ag
Copy link
Member

devilkiller-ag commented Dec 11, 2023

Hi @jonaslagoni, is this issue still unresolved? Also while going through the tools/bundler/index.js file, I found some repetitive spelling mistakes in code comments.

@jonaslagoni
Copy link
Member Author

Still a problem yea, feel free to grab it 🤙

@devilkiller-ag
Copy link
Member

Hi @jonaslagoni, Just to be clear, I need to first move these files from definitions/v3.0.0 to a new folder definitions/common and then update the loadDefinitions function in tools/bundler/index.js accordingly?

@jonaslagoni
Copy link
Member Author

Sounds about right yea @devilkiller-ag 👍

@AnimeshKumar923
Copy link
Contributor

what's the status of this one? @jonaslagoni @devilkiller-ag

@devilkiller-ag
Copy link
Member

Hi @AnimeshKumar923 I am sorry, I forgot this one. I will complete this in the upcoming week as I am currently on vacation.

@Shahbaz898414
Copy link

Hi @jonaslagoni, is this issue still unresolved?

@jonaslagoni
Copy link
Member Author

@Shahbaz898414 its being worked on yes

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants