Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow Reference objects in MultiFormat schema fields #411

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix: allow Reference objects in MultiFormat schema fields #411

merged 1 commit into from
Jul 21, 2023

Conversation

smoya
Copy link
Member

@smoya smoya commented Jul 21, 2023

Description

There was a bug where a multi-format schema wasn't supporting references to external documents. For example, the following schema was invalid:

"ReferencedSchema" : {
    "schemaFormat": "application/vnd.apache.avro;version=1.9.0",
    "schema": {
      "$ref": "reference-to-some-avro-file.avsc"
    }
  }

This PR fixes that by changing schema field to become oneOf either reference object or the schema (asyncapi, avro, etc).

Related issue(s)
https://asyncapi.slack.com/archives/C0230UAM6R3/p1689875953351089

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@smoya smoya mentioned this pull request Jul 21, 2023
Closed
2 tasks
@smoya
Copy link
Member Author

smoya commented Jul 21, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 18c49f7 into asyncapi:next-major-spec Jul 21, 2023
20 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-next-major-spec.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@smoya smoya deleted the fix/schemaReferences branch July 21, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas fmvilas approved these changes

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@char0n char0n Awaiting requested review from char0n char0n is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smoya @asyncapi-bot @fmvilas @derberg