Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OpenAPI 3.0 Schema #362

Merged

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Mar 16, 2023

Description
As done in #348 this PR adds the OpenAPI 3.0 Schema object for all v2 versions.

It is quite a few duplicate schemas... But there is currently no setup to share schemas between versions... Would be great to have at some point. See #364

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there anything needed on the script that creates new definitions for new version

@fmvilas have a look, I think it is good direction, except of my fear against if/then

@jonaslagoni
Copy link
Member Author

is there anything needed on the script that creates new definitions for new version

@derberg Nope there should not 🙂

smoya
smoya previously approved these changes Apr 25, 2023
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@derberg
Copy link
Member

derberg commented Apr 25, 2023

after merging #363 you have some conflicts to solve

@derberg
Copy link
Member

derberg commented Apr 26, 2023

@jonaslagoni I resolve conflicts, I think I did it correct 😅 lemme know

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member Author

@derberg LGTM 👍 Thanks for taking care of this!

@derberg
Copy link
Member

derberg commented Apr 26, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 73f1f52 into asyncapi:master Apr 26, 2023
@jonaslagoni jonaslagoni deleted the feature/add_openapi_schema_for_v2_x branch April 26, 2023 14:11
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants