Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: better maintainability of multi-format messages #535

Merged

Conversation

jonaslagoni
Copy link
Member

Description
This PR adds better maintainability of the different multi-format messages.

dalelane
dalelane previously approved these changes May 14, 2024
derberg
derberg previously approved these changes May 14, 2024
@jonaslagoni jonaslagoni changed the base branch from master to next-major May 21, 2024 14:02
@jonaslagoni jonaslagoni dismissed stale reviews from derberg and dalelane May 21, 2024 14:02

The base branch was changed.

@jonaslagoni jonaslagoni requested a review from derberg May 21, 2024 14:03
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@smoya
Copy link
Member

smoya commented May 22, 2024

Is this a real BC? Couldn't this be merged right into master ?

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jonaslagoni jonaslagoni merged commit 0537d03 into asyncapi:next-major May 22, 2024
9 checks passed
@jonaslagoni jonaslagoni deleted the maintainable_multi_format_messages branch May 22, 2024 08:46
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 7.0.0-next-major.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants