Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $id to some objects #373

Open
fmvilas opened this issue Apr 17, 2020 · 4 comments
Open

Add $id to some objects #373

fmvilas opened this issue Apr 17, 2020 · 4 comments
Labels
keep-open Prevents stale bot from closing this issue or PR

Comments

@fmvilas
Copy link
Member

fmvilas commented Apr 17, 2020

stoplightio/spectral#974 (comment)

Thanks, @nulltoken!
@fmvilas fmvilas added this to the AsyncAPI specification 2.0.1 milestone Apr 17, 2020
@fmvilas fmvilas mentioned this issue Apr 17, 2020
Merged
10 tasks
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Jun 17, 2020
@nulltoken
Copy link

Please, dear bot, don't mark it as stale <3

@derberg derberg added keep-open Prevents stale bot from closing this issue or PR feature request and removed stale labels Jun 17, 2020
@fmvilas fmvilas modified the milestones: AsyncAPI specification 2.0.1, AsyncAPI specification 2.1.0 Jan 31, 2021
@fmvilas fmvilas removed this from the Next specification version milestone May 12, 2021
@github-actions github-actions bot added the stale label Oct 5, 2021
@asyncapi asyncapi deleted a comment from github-actions bot Oct 5, 2021
@derberg derberg removed the stale label Oct 5, 2021
@Anshul439
Copy link

Can someone explain this issue, like which particular objects are being talked about?

@fmvilas
Copy link
Member Author

fmvilas commented Jan 10, 2025

I think this can be closed. We already provide schemas with $id and without $id: https://github.com/asyncapi/spec-json-schemas/tree/master/schemas.

@derberg @jonaslagoni @smoya correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keep-open Prevents stale bot from closing this issue or PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nulltoken @fmvilas @derberg @Anshul439