Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visibility of Blocks visualiser when error #1145

Conversation

catosaurusrex2003
Copy link
Contributor

@catosaurusrex2003 catosaurusrex2003 commented Oct 1, 2024

Description
Editor retains the previous version of the document when an error occurs, Hence doesn't assume it to be not a version 3 document.

BEFORE https://github.com/user-attachments/assets/f6fadd7a-443c-407e-af61-df8699090614

AFTER https://github.com/user-attachments/assets/263d3ecd-41e2-45fb-986f-e2edf136f6f4

Related issue(s)
#1142

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: c776266

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/studio Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit c776266
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/66ffbf71aec24c00087f2c18
😎 Deploy Preview https://deploy-preview-1145--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for studio-next failed.

Name Link
🔨 Latest commit c776266
🔍 Latest deploy log https://app.netlify.com/sites/studio-next/deploys/66ffbf714de777000896064a

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit c776266
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/66ffbf712cb6e60008211dc1
😎 Deploy Preview https://deploy-preview-1145--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Oct 4, 2024

@catosaurusrex2003
Copy link
Contributor Author

/ptal

@asyncapi-bot
Copy link
Contributor

@Amzani @magicmatatjahu @KhudaDad414 @Shurtu-gal Please take a look at this PR. Thanks! 👋

Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shurtu-gal Shurtu-gal merged commit 0336253 into asyncapi:master Oct 10, 2024
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants