-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : add studio tour for first time user #1120
Conversation
|
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for studio-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This PR is ready to review. |
Is it just me or nobody is able to see the tour? |
Hey @Shurtu-gal !! It is working fine for me : https://deploy-preview-1120--modest-rosalind-098b67.netlify.app/ changes are done in : app/studio you can run the tour again : |
@asyncapi/bounty_team |
Updates: I have told @aialok to do a comparison b/w various option such as react-joyride and create an |
@Mayaleeeee Please review the design of the popover. Thank you : ) |
Great work @aialok 🚀. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with all the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, left a few suggestions.
Thank you @KhudaDad414 , done with requested changes : ) |
Sure..Sure...conflict in pkg json and lock file...little hard too to do..but lemme do it : ) |
@aialok there are some problems with the lock file. The deployment is failing. |
@Shurtu-gal might be because there is some conflict in the lock file...I just resolve the conflict. Can I delete lock file and generate new one and push it? |
Yeah, that would be great 😃 |
@Shurtu-gal I have resolved all the conflict. Please merge it. It's been so long : ) |
@Amzani could you please approve the workflows and approve this. |
Fixing Build failed...hold on : ) |
Also @aialok could you run |
Fixes the build : ) |
|
@aeworxet fixing it : ) |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Shurtu-gal It got approved now. Can we go with the merge? |
/rtm |
Absolutely, mate 🚀. Great work!! |
It was really fun to work with you ❤️❤️ |
Description
Related issue(s)
Here's is snapshot :
Screencast.from.2024-06-27.22-55-36.webm