-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Contributor Guide and Maintenance Setup #2586
Comments
💯 agree!! Easy YES 🙌🏽 Thank you for coming up with this proposal, I genuinely think it's a genius & responsible way to grow our maintainers. |
In and up for it 🚀 A small experience I would like to add from the Meshery organization. They invite folks to this team if they seem important to the org. This helps them in the following ways:
Assigning Issues:I saw people are creating issues and multiple contributors throw some PR to that same issue. We can reduce this by assigning those issues to the contributors who ask for the assignment by commenting on that issue. (Most orgs don't go for this "Issue Assignment" path because it sometimes blocks important issues as new contributors try to grab those issues and show no-activity. This can be reduce too, if we allow only some kind of issues to be assigned, like issues labelled with good-first-issue)
Suggestions/Thoughts? |
@anshgoyalevil thanks for all the input! The only document I found is https://github.com/meshery/meshery/blob/master/GOVERNANCE.md and as I understand,
|
Yes, exactly. Totally agree with you. Let's kick off all this, and test out things iteratively, while keeping what would work best for the organization and maintainers/triagers |
@anshgoyalevil I'm not confident about assigning issues to contributors. According to your concept, we can't assign medium-level issues to any new contributor, right? In that manner, we are not providing an appropriate opportunity for a contributor to showcase the skills, the contributor has. We can open all issues to new contributors and will wait for some activity from the contributor's side. If the contributor fails to show any progress on the issue, we can reassign the issue to another contributor, who is willing to work on the issue. @derberg Regarding the current state of the CODEOWNERS file, I'm only concerned with @magicmatatjahu, and whether he wants to continue contributing to the project or not. Can you confirm this once from him? |
@akshatnema We can assign medium (and even hard issues too). The idea of allowing issues with good first issues was exemplary and we need to finalize things by testing iteratively and seeing the community responses. Some repository triagers ask for a brief explanation/approach of how the contributor would tackle the issue. This ensures that the contributor is "Actually Interested" in the issue, and thus medium to hard issues are assigned upon a satisfactory response. |
📣 😈 I'm excited and proud to nominate the following docs contributors to be granted
|
@alequetzalli sounds amazing but also you folks will have a great challange of coordinating the work. Please make sure you do it in open documentation channel in slack as it will be a great learning experience for others. |
Just checked and technically we will solve it this way:
I tested with @magicmatatjahu and if someone is in CODEOWNER but on So I think we are ready to go:
|
Definitely! we'll all use |
Sure, I will do it 🚀 But, I need to have Admins permission for that. I think @derberg forgot to switch back my permissions on repo 😅 . Can anyone do that? cc: @fmvilas |
Got resolved. I've a suggestion. Due to increase of maintainers inside the website repo, there is a long list inside settings to handle the maintainers. Instead, we should now maintain teams inside maintainers, to manage the access and number of maintainers inside website repo. WDYT ? @alequetzalli @derberg @anshgoyalevil @sambhavgupta0705 @thulieblack Teams will be like:-
We then only have to invite members inside the team and rest of the permissions will be automatically handled by Github. |
@akshatnema done 😉 |
Sounds good to me @akshatnema 🙌🏽 |
yo, did anyone start working on new contributor guide that follows what we agreed in here? |
Not as yet; I can put up an issue for it in the coming week |
Personally I think that the best would be if the new guide is drafted by people that will be triage maintainers. The main change here is about triager role, so best if people we enabled to do this role could draft the new guide. That would be @sambhavgupta0705 @octonawish-akcodes @TRohit20 @BhaswatiRoy @VaishnaviNandakumar @Arya-Gupta @J0SAL Thoughts? |
I'll raise a draft PR soon for this, we all can collaborate over there @derberg |
@octonawish-akcodes any progress? |
Hi @derberg I am not getting enough time due to my college and current internship :// |
@derberg, since these onboarding guides now fall under our 2024 GSoD proposal projects, we'll move them forward that way 👍🏻 @octonawish-akcodes, it doesn’t sound like we can rely on you to commit for docs triager tasks or these docs contributions... I think it makes sense to relieve you of this docs contribution since it will now become a 2024 GSoD task, pending selection from google of course 😸 |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
In progress: #2959 |
What we want to propose is not something new in the open-source realm. Every project at scale has, at some point, faced issues that we are currently encountering on the website - gaining popularity and a large number of contributors, which means:
To be completely honest, there is not much new there. Rules like "open an issue first" and others have been there from the beginning, but we did not enforce them because of a lack of time. Now, the goal is to strictly follow the contributor guide.
Contributor Guide changes
I suggest small changes and opting out from the main guide, which means the website will have to be added to the ignore list here.
New Maintenance Setup
Current state:
It means we have:
@alequetzalli is the maintainer of docs.
@thulieblack is the maintainer of community content.
@Mayaleeeee is the designer we ask for an opinion where design changes are part of the PR.
@derberg @akshatnema @magicmatatjahu are code reviewers and approvers.
We have only one level of maintainers - just responsible for different parts of the repo. They all do everything, from issue triage to PR review.
The plan is to introduce two levels of maintainers - to split responsibilities into 2 roles:
Just to make it clear: we are not reinventing the wheel here. You can look up the Django, React, Kubernetes, or Node.js communities to see how they deal with projects when the amount of work is getting out of hand. In short, we can summarize that the solution more or less is always: split into 2 groups - people that review and approve and people that do triage (sometimes project form triage teams)
Proposal:
Split "Maintainer" Role into TWO:
Triager - description inspired by the Node.js community:
Committer
Both, committer and triager, are part of the CODEOWNER file.
We preserve the current separation of duties related to specific topics. In other words, there are still committers just for docs or committers just for design. The same applies to triagers: there can be a triager that is responsible only for code-related issues/PRs, and there can be a triager that is responsible only for docs-related issues/PRs.
New Setup proposal
Thoughts?
The text was updated successfully, but these errors were encountered: