feat: migrate asyncapi3comparison and tabs #2769
Conversation
vishvamsinh28
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
… MigrateAsyncapi3comparison
|
|
||
| /** | ||
| * @description Component for comparing AsyncAPI versions based on ID and address. | ||
| * @param {AsyncAPI3IdAndAddressComparisonProps} props - Props for the component. |
There was a problem hiding this comment.
create separate params like props.className inside jsDoc comments.
There was a problem hiding this comment.
define these types in the component file itself, since these types are specific to those components only.
|
@akshatnema @anshgoyalevil updated the pr |
components/Asyncapi3Comparison/Asyncapi3IdAndAddressComparison.tsx
Outdated
Show resolved
Hide resolved
components/Asyncapi3Comparison/Asyncapi3IdAndAddressComparison.tsx
Outdated
Show resolved
Hide resolved
components/Asyncapi3Comparison/Asyncapi3IdAndAddressComparison.tsx
Outdated
Show resolved
Hide resolved
components/Asyncapi3Comparison/Asyncapi3IdAndAddressComparison.tsx
Outdated
Show resolved
Hide resolved
components/Asyncapi3Comparison/Asyncapi3SchemaFormatComparison.tsx
Outdated
Show resolved
Hide resolved
components/Asyncapi3Comparison/Asyncapi3SchemaFormatComparison.tsx
Outdated
Show resolved
Hide resolved
components/Asyncapi3Comparison/Asyncapi3SchemaFormatComparison.tsx
Outdated
Show resolved
Hide resolved
components/Asyncapi3Comparison/Asyncapi3SchemaFormatComparison.tsx
Outdated
Show resolved
Hide resolved
components/Asyncapi3Comparison/Asyncapi3ParameterComparison.tsx
Outdated
Show resolved
Hide resolved
| </div> | ||
| <div className='ml-1 flex-1 border border-black p-2'> | ||
| <h3 className='mb-4 ml-2 font-sans text-lg font-medium'>AsyncAPI 3.0</h3> | ||
|
|
There was a problem hiding this comment.
@vishvamsinh28 Kindly avoid these unnecessary blank lines.
| </div> | ||
| </div> | ||
| </div> | ||
| </div > |
There was a problem hiding this comment.
| </div > | |
| </div> |
Specify this closing div tag properly
|
@akshatnema updated the pr and removed unnecessary line breaks |
types/tabs/tabs.ts
Outdated
There was a problem hiding this comment.
Include these types in the Tabs component itself.
components/tabs/Tabs.tsx
Outdated
|
|
||
| /** | ||
| * @description Tabs component to display a set of tabs with associated content. | ||
| * @param {TabsProps} props - The props for the Tabs component. |
There was a problem hiding this comment.
Explain each object inside the props in the jsDoc.
| * @param {string} [props.className=''] - Additional CSS classes for styling. | ||
| * @description React component for comparing AsyncAPI schema formats between versions 2.x and 3.0. |
There was a problem hiding this comment.
provide @description above @param.
… MigrateAsyncapi3comparison
|
@akshatnema pr updated |
|
@vishvamsinh28 resolve the lint errors. |
|
@akshatnema lint error fixed |
|
/rtm |
migrated asyncapi3comparison and tabs