Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Docs Bug 🐞 report]: #3167 #3172

Closed
wants to merge 2 commits into from

Conversation

hritikkkkk
Copy link

Description

This pull request addresses a documentation bug. The changes ensure that the documentation now accurately reflects the functionality and usage of the affected components.

I have followed the contribution guidelines.
I have tested the changes to ensure they resolve the issue.
Please review the updated documentation and let me know if any additional improvements are needed.
screenshots are added below:-
Screenshot (539)
Screenshot (538)
Screenshot (537)
Screenshot (536)

Related issue(s)

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1312b8f
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66d6efdd50f9bb0008ceeba7
😎 Deploy Preview https://deploy-preview-3172--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Aug 29, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 38
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3172--asyncapi-website.netlify.app/

@hritikkkkk hritikkkkk changed the title Fix:[Docs Bug 🐞 report]: #3167 fix:[Docs Bug 🐞 report]: #3167 Aug 29, 2024
@hritikkkkk hritikkkkk changed the title fix:[Docs Bug 🐞 report]: #3167 fix: [Docs Bug 🐞 report]: #3167 Aug 30, 2024
@sambhavgupta0705
Copy link
Member

@hritikkkkk are you willing to work on this as there is one more PR for this issue

Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sambhavgupta0705 This looks to me like a very simple typo fix. Are you sure this is the entire PR or am I missing something?

Because the description seems to be too sophisticated if it is just for this typo. So is this a PR in progress?

@sambhavgupta0705
Copy link
Member

closing this because of no response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants