Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated handle link of alequetzalli #3185

Closed

Conversation

lucky29-git
Copy link

Description
Updated github handle link of alequetzalli everywhere in asyncapi/website, from https://github.com/alequetzalli to https://github.com/quetzalliwrites.

Related issue(s) Resolve #3176

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for asyncapi-website failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 11696ad
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66e84f276f8dee00086e75f3

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Sep 2, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 43
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3185--asyncapi-website.netlify.app/

@lucky29-git lucky29-git changed the title updated handle link of alequetzalli docs: updated handle link of alequetzalli Sep 4, 2024
@anshgoyalevil
Copy link
Member

@lucky29-git There are a lot more occurrences of alequetzalli in the whole codebase. Can you please replace all of them? Find and Replace All is all it would take I guess 😃

@lucky29-git
Copy link
Author

okay @anshgoyalevil, working on it.

@@ -64,7 +64,7 @@
"login": "alequetzalli",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this one also

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sambhavgupta0705 the login value?

README.md Outdated
@@ -309,7 +309,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<td align="center" valign="top" width="14.28%"><a href="http://www.fmvilas.com/"><img src="https://avatars.githubusercontent.com/u/242119?v=4?s=100" width="100px;" alt="Fran Méndez"/><br /><sub><b>Fran Méndez</b></sub></a><br /><a href="https://github.com/asyncapi/website/commits?author=fmvilas" title="Code">💻</a> <a href="https://github.com/asyncapi/website/commits?author=fmvilas" title="Documentation">📖</a> <a href="https://github.com/asyncapi/website/issues?q=author%3Afmvilas" title="Bug reports">🐛</a> <a href="#design-fmvilas" title="Design">🎨</a> <a href="#maintenance-fmvilas" title="Maintenance">🚧</a> <a href="#infra-fmvilas" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="#ideas-fmvilas" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/asyncapi/website/pulls?q=is%3Apr+reviewed-by%3Afmvilas" title="Reviewed Pull Requests">👀</a> <a href="#blog-fmvilas" title="Blogposts">📝</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://dev.to/derberg"><img src="https://avatars.githubusercontent.com/u/6995927?v=4?s=100" width="100px;" alt="Lukasz Gornicki"/><br /><sub><b>Lukasz Gornicki</b></sub></a><br /><a href="https://github.com/asyncapi/website/commits?author=derberg" title="Code">💻</a> <a href="https://github.com/asyncapi/website/commits?author=derberg" title="Documentation">📖</a> <a href="https://github.com/asyncapi/website/issues?q=author%3Aderberg" title="Bug reports">🐛</a> <a href="#design-derberg" title="Design">🎨</a> <a href="#maintenance-derberg" title="Maintenance">🚧</a> <a href="#infra-derberg" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="#ideas-derberg" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/asyncapi/website/pulls?q=is%3Apr+reviewed-by%3Aderberg" title="Reviewed Pull Requests">👀</a> <a href="#blog-derberg" title="Blogposts">📝</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/magicmatatjahu"><img src="https://avatars.githubusercontent.com/u/20404945?v=4?s=100" width="100px;" alt="Maciej Urbańczyk"/><br /><sub><b>Maciej Urbańczyk</b></sub></a><br /><a href="https://github.com/asyncapi/website/commits?author=magicmatatjahu" title="Code">💻</a> <a href="https://github.com/asyncapi/website/commits?author=magicmatatjahu" title="Documentation">📖</a> <a href="https://github.com/asyncapi/website/issues?q=author%3Amagicmatatjahu" title="Bug reports">🐛</a> <a href="#design-magicmatatjahu" title="Design">🎨</a> <a href="#maintenance-magicmatatjahu" title="Maintenance">🚧</a> <a href="#infra-magicmatatjahu" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="#ideas-magicmatatjahu" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/asyncapi/website/pulls?q=is%3Apr+reviewed-by%3Amagicmatatjahu" title="Reviewed Pull Requests">👀</a> <a href="#blog-magicmatatjahu" title="Blogposts">📝</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/alequetzalli"><img src="https://avatars.githubusercontent.com/u/19964402?v=4?s=100" width="100px;" alt="Alejandra Quetzalli "/><br /><sub><b>Alejandra Quetzalli </b></sub></a><br /><a href="https://github.com/asyncapi/website/commits?author=alequetzalli" title="Documentation">📖</a> <a href="https://github.com/asyncapi/website/pulls?q=is%3Apr+reviewed-by%3Aalequetzalli" title="Reviewed Pull Requests">👀</a> <a href="#talk-alequetzalli" title="Talks">📢</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/quetzalliwrites"><img src="https://avatars.githubusercontent.com/u/19964402?v=4?s=100" width="100px;" alt="Alejandra Quetzalli "/><br /><sub><b>Alejandra Quetzalli </b></sub></a><br /><a href="https://github.com/asyncapi/website/commits?author=alequetzalli" title="Documentation">📖</a> <a href="https://github.com/asyncapi/website/pulls?q=is%3Apr+reviewed-by%3Aalequetzalli" title="Reviewed Pull Requests">👀</a> <a href="#talk-alequetzalli" title="Talks">📢</a></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are still many occurence of alequetzalli

@sambhavgupta0705
Copy link
Member

https://github.com/search?q=repo%3Aasyncapi%2Fwebsite%20alequetzalli&type=code

@lucky29-git please see this and fix all the occurences

@sambhavgupta0705
Copy link
Member

/update

@sambhavgupta0705
Copy link
Member

we import cli ,glee and generator docs from there repository so don't make changes in those files

@lucky29-git
Copy link
Author

@sambhavgupta0705 sorry I was busy, I had my exams
Doing it right now!

@lucky29-git
Copy link
Author

lucky29-git commented Sep 10, 2024

@sambhavgupta0705 I checked, there are 19 files having github handle link of alequetzalli
and I've updated them all.
Also there are few reference of gist updating them too.

aa-4

@lucky29-git
Copy link
Author

The rest remaining are in glee, cli and other repos.
Do I need to update them too?

@lucky29-git
Copy link
Author

@sambhavgupta0705 is there anything else?

@sambhavgupta0705
Copy link
Member

@lucky29-git you need to check all the occurence of alequetzalli and change it
You have only changed the github handle but not the name so this PR is incomplete

@lucky29-git
Copy link
Author

Okay I'm changing the name also.

@lucky29-git
Copy link
Author

@sambhavgupta0705 I've updated the github handle, gist handle, twitter handle and name.
can you check it please, if anything left?

@sambhavgupta0705
Copy link
Member

@TRohit20 can you please take a look at this PR

Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the link seems to be fixed for most Github & twitter occurrences as I see. So, LGTM!

But again, there could be couple of places that we might have left out.

Request @lucky29-git to have a double check before getting it merged.

Makes sense?

@lucky29-git
Copy link
Author

@TRohit20 Yeah, I've double-checked, and everything looks good to me as well.

@lucky29-git
Copy link
Author

@TRohit20 how can I fix this?
aa-5

@lucky29-git
Copy link
Author

Hey @TRohit20 is there any update?

Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lucky29-git, We need @quetzalliwrites to approve and merge :) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs Bug 🐞 report]: Github handle link of alequetzalli is not working
5 participants