Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: case study card linking to the wrong url #3232

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

JeelRajodiya
Copy link
Contributor

Description

  • The case study card was linking to the /[id] instead of casestudies/[id]

Related issue(s)
Closes #3231

Copy link

netlify bot commented Sep 14, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2396833
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66ec18c2ecea110008349ad4
😎 Deploy Preview https://deploy-preview-3232--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JeelRajodiya JeelRajodiya changed the title fix: Case study card linking to the wrong url fix: case study card linking to the wrong url Sep 14, 2024
@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Sep 14, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 48
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3232--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member

Was this issue due to OG tags ??

@JeelRajodiya
Copy link
Contributor Author

JeelRajodiya commented Sep 17, 2024

Was this issue due to OG tags ??

Oh yes. We have made these changes in the OG tag PR because it was throwing hydration errors. but these errors are not visible now. I think it they were solved as the issue progressed.

Old screenshot

image

@sambhavgupta0705
Copy link
Member

@akshatnema we made this change during og tags issue.
I think we can merge this one to fix the error

Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sambhavgupta0705
Copy link
Member

/update

@sambhavgupta0705
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 84f3222 into asyncapi:master Sep 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Clicking on the Case study card redirects to 404 page
4 participants