-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes gap between Github & View Docs Button on smaller screens (#3008) #3263
base: master
Are you sure you want to change the base?
fixes gap between Github & View Docs Button on smaller screens (#3008) #3263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
We require all PRs to follow Conventional Commits specification.
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3263--asyncapi-website.netlify.app/ |
WalkthroughThe changes in this pull request include an update to a comment in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
pages/tools/generator.tsx (1)
35-35
: Improved button layout and consistencyThe changes to the "View Docs" button classes enhance its responsiveness and alignment:
- Using
md:ml-2
instead ofml-2
improves layout on smaller screens.- Changing to
w-fit
allows the button to shrink to its content width.These modifications align well with the PR objectives. For consistency with the GitHub button, consider using
w-full sm:w-fit
instead of justw-fit
.Consider updating the class to
w-full sm:w-fit md:ml-2 mt-2 block md:mt-0 md:inline-block
for better consistency with the GitHub button styling.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- next-env.d.ts (1 hunks)
- pages/tools/generator.tsx (2 hunks)
✅ Files skipped from review due to trivial changes (1)
- next-env.d.ts
🔇 Additional comments (3)
pages/tools/generator.tsx (3)
19-19
: Improved button spacingThe addition of the
space-y-5
class enhances the layout by introducing consistent vertical spacing between buttons. This change directly addresses the PR objective of improving button alignment and spacing on smaller screens.
29-29
: Improved button responsivenessThe change from
sm:w-auto
tosm:w-fit
for the GitHub button improves its responsiveness. On larger screens, the button will now shrink to fit its content, preventing unnecessary whitespace. This aligns well with the PR objective of adjusting button widths based on content.
Line range hint
19-35
: Summary: PR objectives successfully addressedThe changes in this file effectively address the PR objectives:
- The spacing between buttons has been improved with the addition of
space-y-5
.- Button widths have been adjusted to fit their content on larger screens while maintaining full width on mobile.
- The layout has been optimized for smaller screens by adjusting margins and display properties.
These modifications enhance the responsiveness and visual appeal of the Generator page, particularly on smaller screens. The changes are well-implemented and align with the intended improvements shown in the before and after images mentioned in the PR description.
On smaller screens the buttons were not properly aligned and having spacing issues.
--> Added Vertical Spacing
--> Set view docs content width to fit. ( So that only occupies width as per the content )
Before
after
Summary by CodeRabbit
New Features
Bug Fixes
Documentation