Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add finishing details to the v3 release blog #2316

Conversation

jonaslagoni
Copy link
Member

Description
This PR adds links and overviews to each section. Until we release the website, the links will be slightly broken, but no other way to do it right now.

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit 9aa65a5
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/65605b277b5970000807af37
😎 Deploy Preview https://deploy-preview-2316--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also replace the blog post cover with the image I posted on this issue: asyncapi/community#934 (comment).

pages/blog/release-notes-3.0.0.md Outdated Show resolved Hide resolved
thulieblack and others added 2 commits November 24, 2023 10:12
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
@fmvilas fmvilas mentioned this pull request Nov 24, 2023
13 tasks
@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 9725aa0 into asyncapi:next-major-spec Nov 28, 2023
10 checks passed
@fmvilas
Copy link
Member

fmvilas commented Nov 30, 2023

@jonaslagoni you forgot about this comment of mine:

We should also replace the blog post cover with the image I posted on this issue: asyncapi/community#934 (comment).

@thulieblack
Copy link
Member

@jonaslagoni can we revert this merged PR because there are a few things missing:

  1. Date needs to be on the 6th of December, not the 12, as we will be using it as our announcement blog.
  2. The cover for the blog needs to change to the v3 design ➡️ Design a blog post cover for the announcement community#934

@jonaslagoni
Copy link
Member Author

No need to revert, just do another PR @thulieblack

@jonaslagoni jonaslagoni deleted the finishing_details_release_blog branch December 4, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants