docs: highlight <code/>, correct typos and servers.md <CodeBlock/> #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock highlight in tutorials __Enhancement:__ The code tags should appear bold everywhere in the docs __Typo:__ Found some typos in tutorials + missing of proper redirects. __Fix:__ The Codeblock in servers.md in not hightlighted correctly. Signed-off-by: nikhilkalburgi <nikhilkalburgi19@gmail.com>
nikhilkalburgi
requested review from
quetzalliwrites,
asyncapi-bot-eve,
derberg,
akshatnema,
magicmatatjahu and
Mayaleeeee
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2523--asyncapi-website.netlify.app/ |
akshatnema
reviewed
Jan 13, 2024
| @@ -340,4 +340,8 @@ abbr[title] { | |||
|
|
|||
| .meeting-card:hover > div:nth-child(2) > p { | |||
| color: white; | |||
| } | |||
|
|
|||
| code{ | |||
There was a problem hiding this comment.
Why have you made font-weight bold here?
There was a problem hiding this comment.
Hi @akshatnema,
The <code/> content are not highlighted well and the users cannot identify the keywords used in the docs.
Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
Fixes #2522