feat: migrate leftover components to typescript #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
devilkiller-ag
changed the title
devilkiller-ag
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
akshatnema
requested changes
Apr 6, 2024
components/CaseTOC.tsx
Outdated
| closeMenu(); | ||
| setOpen(false); | ||
| }; | ||
| const active = useMemo(() => checkIfActive(item, currSelected), [item, currSelected]); |
There was a problem hiding this comment.
Define this above, in next line of open state.
components/Testimonial.tsx
Outdated
Comment on lines
32
to
38
| <svg | ||
| className='absolute left-0 top-0 size-8 -translate-y-2 text-primary-500' | ||
| fill='currentColor' | ||
| viewBox='0 0 32 32' | ||
| > | ||
| <path d='M9.352 4C4.456 7.456 1 13.12 1 19.36c0 5.088 3.072 8.064 6.624 8.064 3.36 0 5.856-2.688 5.856-5.856 0-3.168-2.208-5.472-5.088-5.472-.576 0-1.344.096-1.536.192.48-3.264 3.552-7.104 6.624-9.024L9.352 4zm16.512 0c-4.8 3.456-8.256 9.12-8.256 15.36 0 5.088 3.072 8.064 6.624 8.064 3.264 0 5.856-2.688 5.856-5.856 0-3.168-2.304-5.472-5.184-5.472-.576 0-1.248.096-1.44.192.48-3.264 3.456-7.104 6.528-9.024L25.864 4z' /> | ||
| </svg> |
There was a problem hiding this comment.
Make separate icon for this SVG.
asyncapi-bot
requested review from
BhaswatiRoy,
J0SAL,
octonawish-akcodes,
TRohit20 and
VaishnaviNandakumar
akshatnema
reviewed
Apr 6, 2024
Comment on lines
+87
to
+103
| useLayoutEffect(() => { | ||
| if (!graph) { | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| const svgElement = document.createElement('div'); | ||
|
|
||
| mermaid.mermaidAPI.render(uuid(), graph, svgElement).then(() => { | ||
| setSvg(svgElement.innerHTML); | ||
| }); | ||
| } catch (e) { | ||
| setSvg(null); | ||
| // eslint-disable-next-line no-console | ||
| console.error(e); | ||
| } | ||
| }, [graph]); |
akshatnema
approved these changes
Apr 7, 2024
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the components inside the following folder to TypeScript:
Related issue(s)
#2636