Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to employees endpoint #41

Open
FriedrichtenHagen opened this issue Nov 25, 2024 · 3 comments
Open

Add pagination to employees endpoint #41

FriedrichtenHagen opened this issue Nov 25, 2024 · 3 comments

Comments

@FriedrichtenHagen
Copy link

I have received an email from personio saying that the employee endpoint will be paginated starting from 2024-12-07.
At the moment get_employees uses request_json which does not handle pagination.
Just switching to request_paginated may be enough (?).

From the personio docs:
In order to maintain system integrity and acceptable performance at V1 GET employees endpoint the maximum page size will be reduced to 100 employees per page on an ongoing basis in 2025.

The docs do not mention the deadline that I have received via email. Anyways this seems like an easy fix and I am happy to make a PR.

Screenshot 2024-11-25 at 16 32 34

@FriedrichtenHagen
Copy link
Author

I am working on a pr now.

@FriedrichtenHagen
Copy link
Author

PR is here: #42

@klamann
Copy link
Contributor

klamann commented Nov 30, 2024

Hi, I'm not with Alexander Thamm anymore and don't have access to Personio, so I have no way to test any changes.

@at-gmbh anyone interested in maintaining this project? Otherwise it would probably make sense to fork it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants