Small code fixes.

atbashEE · Aug 2, 2018 · ad9cb7a · ad9cb7a
1 parent 1bd2ce1
commit ad9cb7a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/src/main/java/be/atbash/ee/security/octopus/keys/config/JwtSupportConfiguration.java b/src/main/java/be/atbash/ee/security/octopus/keys/config/JwtSupportConfiguration.java
@@ -44,7 +44,7 @@ public class JwtSupportConfiguration extends AbstractConfiguration implements Mo
     /**
      * The return value can also be a directory where multiple files are located (and retrieved).
      *
-     * @return
+     * @return Location, file or directory where the keys are located.
      */
     @ConfigEntry
     public String getKeysLocation() {

diff --git a/src/main/java/be/atbash/ee/security/octopus/keys/reader/KeyReader.java b/src/main/java/be/atbash/ee/security/octopus/keys/reader/KeyReader.java
@@ -57,7 +57,6 @@ public List<AtbashKey> readKeyResource(String path, KeyResourcePasswordLookup pa
         if (keyResourceType == null) {
             throw new UnknownKeyResourceTypeException(path);
         }
-        // FIXME keyResourceType == null -> Exception.
         switch (keyResourceType) {
 
             case JWK:

diff --git a/src/main/java/be/atbash/ee/security/octopus/keys/reader/KeyReaderKeyStore.java b/src/main/java/be/atbash/ee/security/octopus/keys/reader/KeyReaderKeyStore.java
@@ -43,7 +43,7 @@ public class KeyReaderKeyStore {
     public List<AtbashKey> readResource(String path, KeyResourcePasswordLookup passwordLookup) {
         List<AtbashKey> result = new ArrayList<>();
 
-        KeyStore keyStore = null;
+        KeyStore keyStore;
         try {
             keyStore = KeyStore.getInstance(KeyStore.getDefaultType());
         } catch (KeyStoreException e) {

diff --git a/src/main/java/be/atbash/ee/security/octopus/keys/writer/KeyWriter.java b/src/main/java/be/atbash/ee/security/octopus/keys/writer/KeyWriter.java
@@ -144,27 +144,27 @@ private void writeFile(String target, byte[] fileContent) throws IOException {
         outputStream.close();
     }
 
-    public byte[] writeKeyResource(AtbashKey atbashKey, KeyResourceType keyResourceType, char[] keyPasssword, char[] filePassword) {
+    public byte[] writeKeyResource(AtbashKey atbashKey, KeyResourceType keyResourceType, char[] keyPassword, char[] filePassword) {
         checkDependencies();
         byte[] result;
         try {
             switch (keyResourceType) {
 
                 case JWK:
                     // FIXME support for encrypted JWK of Atbash (see JWKEncryptedCreator)
-                    result = writeKeyAsJWK(atbashKey, keyPasssword);
+                    result = writeKeyAsJWK(atbashKey, keyPassword);
                     break;
                 case JWKSET:
                     result = writeKeyAsJWKSet(atbashKey, new JWKSet());
                     break;
                 case PEM:
-                    result = writeKeyAsPEM(atbashKey, keyPasssword);
+                    result = writeKeyAsPEM(atbashKey, keyPassword);
                     break;
                 case KEYSTORE:
                     KeyStore keyStore = KeyStore.getInstance("JKS");
                     keyStore.load(null, null);
 
-                    result = writeKeyAsKeyStore(atbashKey, keyPasssword, filePassword, keyStore);
+                    result = writeKeyAsKeyStore(atbashKey, keyPassword, filePassword, keyStore);
                     break;
                 default:
                     throw new IllegalArgumentException(String.format("Unsupported value for KeyResourceType : %s", keyResourceType));