Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: BackgroundServiceBase & BackgroundServiceHealthService Overhaul #10

Merged
merged 11 commits into from
Sep 29, 2023
Merged

Feature: BackgroundServiceBase & BackgroundServiceHealthService Overhaul #10

merged 11 commits into from
Sep 29, 2023

Conversation

Anders-Toegersen
Copy link
Contributor

Changes

  • feat: Made staleness check optional in BackgroundServiceHealthService
  • feat: Made optional HealthService updates for BackgroundServiceBase
  • fix: Made BackgroundServiceHealthService thread safe
  • feat: Added hookin for unhandled exceptions in BackgroundServiceBase
  • refact: LoggerExtensions into own class
  • feat: Introduced SetInfiniteStaleness in BackgroundServiceHealthService
  • chore: Removed InternalsVisibleTo as it is not needed
  • docs: Removed section about retries
  • test: Added logger test
  • feat: Moved LoggerMessage methods away from BackgroundServiceBase
  • feat: Improved logging
  • fix: Removed RetryCount and Polly

Anders Tøgersen (Delegate) and others added 11 commits September 21, 2023 10:58
@Anders-Toegersen Anders-Toegersen added the enhancement New feature or request label Sep 29, 2023
@Anders-Toegersen
Copy link
Contributor Author

Solves #7

@Anders-Toegersen Anders-Toegersen linked an issue Sep 29, 2023 that may be closed by this pull request
Introduce HealthChecks for BackgroundServices with unknown staleness #7
Closed
@Anders-Toegersen Anders-Toegersen merged commit d479175 into atc-net:main Sep 29, 2023
4 checks passed
@Anders-Toegersen Anders-Toegersen deleted the feature/backgroundservicebase-overhaul branch September 29, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perkops perkops perkops approved these changes

@davidkallesen davidkallesen davidkallesen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce HealthChecks for BackgroundServices with unknown staleness
3 participants
@Anders-Toegersen @davidkallesen @perkops