Merge pull request #34 from atc-net/feature/Remove-static-on-syncLock

Remove static on sync lock

Atc.Network.sln.DotSettings

@@ -1,5 +1,6 @@
 <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=IP/@EntryIndexedValue">IP</s:String>
+	<s:Boolean x:Key="/Default/GrammarAndSpelling/GrammarChecking/Exceptions/=An_0020enumerable_0020of/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=cidr/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Icmp/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Routable/@EntryIndexedValue">True</s:Boolean>

Directory.Build.props

@@ -43,10 +43,10 @@
   <ItemGroup Label="Code Analyzers">
     <PackageReference Include="AsyncFixer" Version="1.6.0" PrivateAssets="All" />
     <PackageReference Include="Asyncify" Version="0.9.7" PrivateAssets="All" />
-    <PackageReference Include="Meziantou.Analyzer" Version="2.0.138" PrivateAssets="All" />
+    <PackageReference Include="Meziantou.Analyzer" Version="2.0.141" PrivateAssets="All" />
     <PackageReference Include="SecurityCodeScan.VS2019" Version="5.6.7" PrivateAssets="All" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.435" PrivateAssets="All" />
-    <PackageReference Include="SonarAnalyzer.CSharp" Version="9.17.0.82934" PrivateAssets="All" />
+    <PackageReference Include="SonarAnalyzer.CSharp" Version="9.19.0.84025" PrivateAssets="All" />
   </ItemGroup>
 
 </Project>

docs/CodeDoc/Atc.Network/Atc.Network.Helpers.md

@@ -8,6 +8,7 @@
 <br />
 
 ## ArpHelper
+Provides utilities for fetching and parsing ARP (Address Resolution Protocol) table results.
 
 >```csharp
 >public static class ArpHelper
@@ -19,10 +20,16 @@
 >```csharp
 >ArpEntity[] GetArpResult()
 >```
+><b>Summary:</b> Retrieves the ARP table results, caching them for 90 seconds to limit frequent lookups.
+>
+><b>Returns:</b> An array of `Atc.Network.Models.ArpEntity` representing the current ARP table entries. Returns an empty array if no connection is available or if the ARP lookup fails.
+>
+><b>Remarks:</b> This method first checks if the results are cached and valid (less than 90 seconds old). If valid, cached results are returned. Otherwise, it performs a new ARP lookup using the system's 'arp' command. The results are parsed, cached, and then returned. If there's no network connection, an empty array is returned.
 
 <br />
 
 ## DnsLookupHelper
+Provides utilities for performing DNS lookups.
 
 >```csharp
 >public static class DnsLookupHelper
@@ -34,10 +41,20 @@
 >```csharp
 >Task<string> GetHostname(IPAddress ipAddress, CancellationToken cancellationToken)
 >```
+><b>Summary:</b> Resolves the hostname for a given IP address asynchronously.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`ipAddress`&nbsp;&nbsp;-&nbsp;&nbsp;The IP address to resolve the hostname for.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`cancellationToken`&nbsp;&nbsp;-&nbsp;&nbsp;A token to monitor for cancellation requests.<br />
+>
+><b>Returns:</b> The hostname associated with the specified IP address or null if the lookup fails or the address is a private IP address for which the local hostname cannot be resolved.
+>
+><b>Remarks:</b> This method uses a SemaphoreSlim to ensure thread-safe access to the hostname and hostAddresses static fields. It first checks if the IP address is a private address. If so, and if the hostname and hostAddresses have not been previously set, it attempts to set them by resolving the local machine's hostname and IP addresses. For public IP addresses, it performs a DNS lookup to resolve the hostname. This method suppresses all exceptions, returning null in case of any errors or if the operation is canceled.
 
 <br />
 
 ## IPv4AddressHelper
+Provides utilities for validating and working with IPv4 addresses.
 
 >```csharp
 >public static class IPv4AddressHelper
@@ -49,26 +66,100 @@
 >```csharp
 >IReadOnlyCollection<IPAddress> GetAddressesInRange(IPAddress startIpAddress, IPAddress endIpAddress)
 >```
+><b>Summary:</b> Generates a collection of IPv4 addresses within a specified range.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`startIpAddress`&nbsp;&nbsp;-&nbsp;&nbsp;The starting IP address of the range.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`endIpAddress`&nbsp;&nbsp;-&nbsp;&nbsp;The ending IP address of the range.<br />
+>
+><b>Returns:</b> A read-only collection of IP addresses within the specified range.
 #### GetAddressesInRange
 >```csharp
 >IReadOnlyCollection<IPAddress> GetAddressesInRange(IPAddress ipAddress, int cidrLength)
 >```
+><b>Summary:</b> Generates a collection of IPv4 addresses within a specified range.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`startIpAddress`&nbsp;&nbsp;-&nbsp;&nbsp;The starting IP address of the range.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`endIpAddress`&nbsp;&nbsp;-&nbsp;&nbsp;The ending IP address of the range.<br />
+>
+><b>Returns:</b> A read-only collection of IP addresses within the specified range.
 #### GetFirstAndLastAddressInRange
 >```csharp
 >ValueTuple<IPAddress, IPAddress> GetFirstAndLastAddressInRange(IPAddress ipAddress, int cidrLength)
 >```
+><b>Summary:</b> Calculates the first and last IP addresses in a subnet given an IP address and CIDR length.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`ipAddress`&nbsp;&nbsp;-&nbsp;&nbsp;The IP address within the subnet.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`cidrLength`&nbsp;&nbsp;-&nbsp;&nbsp;The CIDR notation length of the subnet mask.<br />
+>
+><b>Returns:</b> A tuple containing the first and last IP addresses in the subnet range.
 #### GetLocalAddress
 >```csharp
 >IPAddress GetLocalAddress()
 >```
+><b>Summary:</b> Retrieves the local machine's IPv4 address.
+>
+><b>Returns:</b> The local IPv4 address, or null if not found.
 #### IsValid
 >```csharp
 >bool IsValid(string ipAddress)
 >```
+><b>Summary:</b> Validates if a string is a valid IPv4 address.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`ipAddress`&nbsp;&nbsp;-&nbsp;&nbsp;The IP address in string format to validate.<br />
+>
+><b>Returns:</b> True if the IP address is valid; otherwise, false.
+>
+><b>Remarks:</b> This method checks if the string can be parsed into an IPAddress object and belongs to the IPv4 address family. It also ensures that the IP address string has exactly four octets.
 #### ValidateAddresses
 >```csharp
 >ValueTuple<bool, string> ValidateAddresses(IPAddress startIpAddress, IPAddress endIpAddress)
 >```
+><b>Summary:</b> Validates that two IP addresses are valid IPv4 addresses and that the start IP is less than or equal to the end IP.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`startIpAddress`&nbsp;&nbsp;-&nbsp;&nbsp;The starting IP address of the range.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`endIpAddress`&nbsp;&nbsp;-&nbsp;&nbsp;The ending IP address of the range.<br />
+>
+><b>Returns:</b> A tuple containing a boolean indicating if the addresses are valid and an error message if they are not.
+
+<br />
+
+## InternetWorldTimeHelper
+Provides utilities for fetching the current time from the WorldTimeAPI.
+
+>```csharp
+>public static class InternetWorldTimeHelper
+>```
+
+### Static Methods
+
+#### GetTimeForEuropeBerlin
+>```csharp
+>Task<DateTime?> GetTimeForEuropeBerlin(CancellationToken cancellationToken)
+>```
+><b>Summary:</b> Retrieves the current time for the Europe/Berlin timezone.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`cancellationToken`&nbsp;&nbsp;-&nbsp;&nbsp;A token to monitor for cancellation requests.<br />
+>
+><b>Returns:</b> A `System.DateTime` representing the current time in Europe/Berlin timezone, or null if the operation fails or is canceled.
+#### GetTimeForWorldTimezone
+>```csharp
+>Task<DateTime?> GetTimeForWorldTimezone(string worldTimezone, CancellationToken cancellationToken)
+>```
+><b>Summary:</b> Retrieves the current time for a specified WorldTimeAPI timezone.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`worldTimezone`&nbsp;&nbsp;-&nbsp;&nbsp;The timezone string as defined by WorldTimeAPI.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`cancellationToken`&nbsp;&nbsp;-&nbsp;&nbsp;A token to monitor for cancellation requests.<br />
+>
+><b>Returns:</b> A `System.DateTime` representing the current time in the specified timezone, or null if the operation fails or is canceled.
+>
+><b>Remarks:</b> This method ensures thread safety by using a SemaphoreSlim to limit concurrent access. It checks for network connectivity before making the HTTP request. If the network is unavailable or the request fails, the method returns null.
 
 <br />
 
@@ -88,6 +179,7 @@
 <br />
 
 ## OpcUaAddressHelper
+Provides utilities for validating OPC UA (Open Platform Communications Unified Architecture) addresses.
 
 >```csharp
 >public static class OpcUaAddressHelper
@@ -99,14 +191,33 @@
 >```csharp
 >bool IsValid(string url, bool restrictToIp4Address = False)
 >```
+><b>Summary:</b> Validates the format of a given OPC UA address specified as a URL string.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`url`&nbsp;&nbsp;-&nbsp;&nbsp;The OPC UA address to validate.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`restrictToIp4Address`&nbsp;&nbsp;-&nbsp;&nbsp;Indicates whether to restrict validation to IPv4 addresses only.<br />
+>
+><b>Returns:</b> True if the address is a valid OPC UA address; otherwise, false.
+>
+><b>Remarks:</b> This method checks if the URL is an absolute URI with the scheme "opc.tcp". If `restrictToIp4Address` is true, it further validates that the host part of the URI is a valid IPv4 address.
 #### IsValid
 >```csharp
 >bool IsValid(Uri uri, bool restrictToIp4Address = False)
 >```
+><b>Summary:</b> Validates the format of a given OPC UA address specified as a URL string.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`url`&nbsp;&nbsp;-&nbsp;&nbsp;The OPC UA address to validate.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`restrictToIp4Address`&nbsp;&nbsp;-&nbsp;&nbsp;Indicates whether to restrict validation to IPv4 addresses only.<br />
+>
+><b>Returns:</b> True if the address is a valid OPC UA address; otherwise, false.
+>
+><b>Remarks:</b> This method checks if the URL is an absolute URI with the scheme "opc.tcp". If `restrictToIp4Address` is true, it further validates that the host part of the URI is a valid IPv4 address.
 
 <br />
 
 ## PingHelper
+Provides utilities for performing ping operations to assess network connectivity and response time.
 
 >```csharp
 >public static class PingHelper
@@ -118,14 +229,33 @@
 >```csharp
 >Task<PingStatusResult> GetStatus(IPAddress ipAddress, TimeSpan timeout)
 >```
+><b>Summary:</b> Initiates a ping request to a specified IP address with a timeout.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`ipAddress`&nbsp;&nbsp;-&nbsp;&nbsp;The IP address to ping.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`timeout`&nbsp;&nbsp;-&nbsp;&nbsp;The maximum amount of time to wait for a ping response.<br />
+>
+><b>Returns:</b> A task that represents the asynchronous operation, resulting in a `Atc.Network.Models.PingStatusResult`.
+>
+><b>Remarks:</b> This overload accepts a `System.TimeSpan` for the timeout and converts it to milliseconds before calling the main asynchronous ping method.
 #### GetStatus
 >```csharp
 >Task<PingStatusResult> GetStatus(IPAddress ipAddress, int timeoutInMs = 1000)
 >```
+><b>Summary:</b> Initiates a ping request to a specified IP address with a timeout.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`ipAddress`&nbsp;&nbsp;-&nbsp;&nbsp;The IP address to ping.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`timeout`&nbsp;&nbsp;-&nbsp;&nbsp;The maximum amount of time to wait for a ping response.<br />
+>
+><b>Returns:</b> A task that represents the asynchronous operation, resulting in a `Atc.Network.Models.PingStatusResult`.
+>
+><b>Remarks:</b> This overload accepts a `System.TimeSpan` for the timeout and converts it to milliseconds before calling the main asynchronous ping method.
 
 <br />
 
 ## TerminationHelper
+Provides utilities for appending termination sequences to data arrays.
 
 >```csharp
 >public static class TerminationHelper
@@ -137,10 +267,18 @@
 >```csharp
 >void AppendTerminationBytesIfNeeded(ref byte data, TerminationType terminationType)
 >```
+><b>Summary:</b> Appends termination bytes to a data array if the specified termination type is not already present at the end of the array.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`data`&nbsp;&nbsp;-&nbsp;&nbsp;The data array to append the termination bytes to, if necessary.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`terminationType`&nbsp;&nbsp;-&nbsp;&nbsp;The type of termination sequence to append.<br />
+>
+><b>Remarks:</b> This method first checks if the termination type is None, in which case it does nothing. If the termination type is specified, it converts the termination type to its byte array representation and checks if the data array already ends with this sequence. If not, it appends the termination bytes to the end of the data array.
 
 <br />
 
 ## TerminationTypeHelper
+Provides utilities for handling different types of message termination characters and sequences.
 
 >```csharp
 >public static class TerminationTypeHelper
@@ -170,12 +308,31 @@
 >```csharp
 >byte[] ConvertToBytes(TerminationType terminationType)
 >```
+><b>Summary:</b> Converts a termination type to its byte array representation.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`terminationType`&nbsp;&nbsp;-&nbsp;&nbsp;The termination type to convert.<br />
+>
+><b>Returns:</b> A byte array representation of the specified termination type.
 #### ConvertToString
 >```csharp
 >string ConvertToString(TerminationType terminationType)
 >```
+><b>Summary:</b> Converts a termination type to its string representation.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`terminationType`&nbsp;&nbsp;-&nbsp;&nbsp;The termination type to convert.<br />
+>
+><b>Returns:</b> A string representation of the specified termination type.
 #### HasTerminationType
 >```csharp
 >bool HasTerminationType(TerminationType terminationType, byte[] data)
 >```
+><b>Summary:</b> Checks if the specified data contains the termination sequence for the given termination type.
+>
+><b>Parameters:</b><br>
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`terminationType`&nbsp;&nbsp;-&nbsp;&nbsp;The termination type to check for.<br />
+>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;`data`&nbsp;&nbsp;-&nbsp;&nbsp;The data to search within.<br />
+>
+><b>Returns:</b> True if the data contains the termination sequence; otherwise, false.
 <hr /><div style='text-align: right'><i>Generated by MarkdownCodeDoc version 1.2</i></div>