Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little-endian assumptions #141

Open
lrettig opened this issue Oct 10, 2024 · 2 comments
Open

Little-endian assumptions #141

lrettig opened this issue Oct 10, 2024 · 2 comments

Comments

@lrettig
Copy link
Contributor

lrettig commented Oct 10, 2024

There are probably a bunch of places where we assume LE byte order, and I doubt athena would work on a native BE host today without some fixes. Opening an issue to document this and so we're aware of it. See #137 (comment) and also risc0/risc0#420 (we are not alone here).

@jellonek
Copy link
Collaborator

jellonek commented Nov 5, 2024

So this task is about finding all such places and cover them using https://docs.rs/byteorder/latest/byteorder/type.NativeEndian.html

@lrettig
Copy link
Contributor Author

lrettig commented Nov 5, 2024

Right, but remember that the byte order for compiled Athena programs must be LE, and also that we use LE in serialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants