Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to "zkvm" #16

Open
lrettig opened this issue Jun 8, 2024 · 0 comments
Open

Remove references to "zkvm" #16

lrettig opened this issue Jun 8, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lrettig
Copy link
Contributor

lrettig commented Jun 8, 2024

The "OS" portion of the Rust toolchain target triple is still set to "zkvm": https://github.com/athenavm/rustc-rv32e-toolchain/blob/main/patches/rust.patch. This is a holdover from the forked SP1 code. We should probably switch this to "athena" to avoid confusion. Will require updating the feature flags as well as the Rust toolchain.
@lrettig lrettig added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lrettig